Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add localhost into hosts based on network mode #11445

Merged
merged 1 commit into from
Sep 5, 2021
Merged

Add localhost into hosts based on network mode #11445

merged 1 commit into from
Sep 5, 2021

Conversation

1995parham
Copy link
Contributor

@1995parham 1995parham commented Sep 4, 2021 •
edited
Loading

fixes #11411

@1995parham
Copy link
Contributor Author

/assign baude

@1995parham
Copy link
Contributor Author

1995parham commented Sep 4, 2021 •
edited
Loading

I cannot find any existing test for container_linux_internal and /etc/hosts. I think if you agree I can add a test to create a temporary file to works as hosts and then check the generateHosts function but this function covers many different logics.

for now, I just add a test for my function.

@rhatdan
Copy link
Member

rhatdan commented Sep 4, 2021

LGTM

@Luap99
Copy link
Member

Luap99 commented Sep 4, 2021

Can you squash your commits into one please.

@1995parham
Copy link
Contributor Author

@Luap99 sure I will squash them now.

@mheon
Copy link
Member

mheon commented Sep 5, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2021
@mheon
Copy link
Member

mheon commented Sep 5, 2021

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 5, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 1995parham, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2021
@openshift-merge-robot openshift-merge-robot merged commit fcf995c into containers:main Sep 5, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Luap99 Luap99 Luap99 left review comments

Assignees

@mheon mheon

@baude baude

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

There is no localhost on /etc/hosts
6 participants
@1995parham @rhatdan @Luap99 @mheon @baude @openshift-merge-robot