-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NO TESTS NEEDED] Fix #11418 - Default TMPDIR to /tmp on OS X #11437
[NO TESTS NEEDED] Fix #11418 - Default TMPDIR to /tmp on OS X #11437
Conversation
46d8f62
to
ce09a1b
Compare
Can you remove the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should it not be like ~/tmp as /tmp my not be user writable ?
Signed-off-by: Michael Anckaert <[email protected]>
ce09a1b
to
e151f4c
Compare
@maxandersen The I updated the changes to remove the unused import. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MichaelAnckaert, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
This PR fixes bug #11418 - on OS X there was a bug where podman would fail when the
TMPDIR
environment variable was empty.This commit fixes that issue by defaulting to
/tmp
when that environment variable is empty.