Add filtering functionality to http api secrets list #11431
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
There are some things to do which I must put aside for the next PR or PRs:
The last one is tricky as in podman there is no support for labels in secrets. This should be added as a prerequisite. I will think about this. That's being said, HTTP API filters should be ready right now, fully introduced by this commit |
| "github.com/pkg/errors" | ||
| ) | ||
|
|
||
| func IfPassesSecretsFilter(s secrets.Secret, filters map[string][]string) (bool, error) { |
There was a problem hiding this comment.
Let me know if that file/function location is ok for you.
jmguzik
force-pushed
the
secrets-ls-filters
branch
from
aaa054e to
8b0525b
Compare
Filtering is missing in both compat API and libpod API, while docker has filtering functinality. This commit enables filtering option using name and id in both libpod and http API. Signed-off-by: Jakub Guzik <[email protected]>
jmguzik
force-pushed
the
secrets-ls-filters
branch
from
8b0525b to
d346e6e
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
fails are not related to the PR |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmguzik, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
This PR is a follow-up of containers#11431. It adds possibility of filtering secret list based on id and name. Signed-off-by: Jakub Guzik <[email protected]>
github-actions
bot
added
the
locked - please file new issue/PR
Filtering is missing in both compat API and libpod API, while docker
has filtering functinality. This commit enables filtering option using
name and id in both libpod and http API.
Signed-off-by: Jakub Guzik [email protected]