-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#11408] podman help machine init #11410
[#11408] podman help machine init #11410
Conversation
/assign @TomSweeneyRedHat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing. The changes look good to me. In order pass CI, you need add two things to the commit message:
- It must be signed (i.e., have the Signed-off-by) field. You can do that via
git commit --amend -s
). - Since there's no test file changed, you need to add
[NO TESTS NEEDED]
to the body of the commit message.
Signed-off-by: jesperpedersen <[email protected]> [NO TESTS NEEDED]
9946ba9
to
b3bb7da
Compare
LGTM |
Thanks, Valentin. (Maybe put a tl ;dr; in CONTRIBUTING about minimum requirements) |
/lgtm |
Sounds like a good idea. @TomSweeneyRedHat WDYT? |
/hold cancel |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, jesperpedersen, mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[containers#11408] podman help machine init Signed-off-by: Fabien Benetou aka Utopiah <[email protected]>
Fix for #11408