Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#11408] podman help machine init #11410

Merged
merged 1 commit into from
Sep 2, 2021

Conversation

jesperpedersen
Copy link
Contributor

Fix for #11408

@jesperpedersen
Copy link
Contributor Author

/assign @TomSweeneyRedHat
/assign @baude

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing. The changes look good to me. In order pass CI, you need add two things to the commit message:

  1. It must be signed (i.e., have the Signed-off-by) field. You can do that via git commit --amend -s).
  2. Since there's no test file changed, you need to add [NO TESTS NEEDED] to the body of the commit message.

Signed-off-by: jesperpedersen <[email protected]>

[NO TESTS NEEDED]
@rhatdan
Copy link
Member

rhatdan commented Sep 2, 2021

LGTM

@jesperpedersen
Copy link
Contributor Author

Thanks, Valentin.

(Maybe put a tl ;dr; in CONTRIBUTING about minimum requirements)

@vrothberg
Copy link
Member

/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 2, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2021
@vrothberg
Copy link
Member

(Maybe put a tl ;dr; in CONTRIBUTING about minimum requirements)

Sounds like a good idea. @TomSweeneyRedHat WDYT?

@mheon
Copy link
Member

mheon commented Sep 2, 2021

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 2, 2021
@mheon
Copy link
Member

mheon commented Sep 2, 2021

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 2, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, jesperpedersen, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2021
@openshift-merge-robot openshift-merge-robot merged commit 858d3e4 into containers:main Sep 2, 2021
@jesperpedersen jesperpedersen deleted the issue11408 branch September 4, 2021 05:10
Utopiah pushed a commit to Utopiah/podman that referenced this pull request Sep 5, 2021
[containers#11408] podman help machine init

Signed-off-by: Fabien Benetou aka Utopiah <[email protected]>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants