make podman run --systemd case insensitive #11405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Since boolean flags accept `True` and `False` the systemd flag should do this as well. Fixes containers#11387 Signed-off-by: Paul Holzinger <[email protected]>
Luap99
force-pushed
the
systemd-arg-case
branch
from
c346ab0 to
a077335
Compare
vrothberg
reviewed
Sep 2, 2021
| @@ -176,4 +176,21 @@ WantedBy=multi-user.target | |||
|
|
|||
| Expect(session.OutputToString()).To(Not(ContainSubstring("noexec"))) | |||
| }) | |||
|
|
|||
| It("podman run --systemd arg is case insensitive", func() { | |||
| session := podmanTest.Podman([]string{"run", "--rm", "--systemd", "Always", ALPINE, "echo", "test"}) | |||
There was a problem hiding this comment.
Could we use create instead of run to spare some CI cycles?
There was a problem hiding this comment.
No it failed at runtime before
|
LGTM |
|
/lgtm |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since boolean flags accept
TrueandFalsethe systemd flag should dothis as well.
Fixes #11387