Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add podman-plugins to upstream image #11385

Closed
wants to merge 1 commit into from

Conversation

mattymo
Copy link
Contributor

@mattymo mattymo commented Sep 1, 2021

Fixes #11380

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 1, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mattymo
To complete the pull request process, please assign umohnani8 after the PR has been reviewed.
You can assign the PR to them by writing /assign @umohnani8 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the the upstream image should compile the plugin from source like it is done with the other cni plugins.

@rhatdan
Copy link
Member

rhatdan commented Sep 1, 2021

I agree, it should have the upstream image should include the upstream version of the plugin.

@github-actions
Copy link

github-actions bot commented Oct 2, 2021

A friendly reminder that this PR had no activity for 30 days.

rhatdan pushed a commit to rhatdan/podman that referenced this pull request Oct 4, 2021
Fixes containers#11380
Replaces containers#11385

Originally subbmitted by @mattymo
Signed-off-by: Daniel J Walsh <[email protected]>
@rhatdan rhatdan closed this Oct 4, 2021
mheon pushed a commit to mheon/libpod that referenced this pull request Oct 19, 2021
Fixes containers#11380
Replaces containers#11385

Originally subbmitted by @mattymo
Signed-off-by: Daniel J Walsh <[email protected]>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. stale-pr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upstream podman image should have dnsname plugin installed and enabled
3 participants