Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We don't currently support --mac-address #1138

Closed
wants to merge 1 commit into from

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Jul 23, 2018

Make this clear in the docs and Command.

Fixes #1136

Signed-off-by: Daniel J Walsh [email protected]

Make this clear in the docs and Command.

Signed-off-by: Daniel J Walsh <[email protected]>
@mheon
Copy link
Member

mheon commented Jul 23, 2018

@rhatdan Damn, you beat me.

Should we make the option hidden so people don't accidentally stumble on them?

Copy link
Member

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming happy tests

@rhatdan
Copy link
Member Author

rhatdan commented Jul 23, 2018

bot, retest this please.

@rhatdan
Copy link
Member Author

rhatdan commented Jul 24, 2018

bot, retest this please

@mheon
Copy link
Member

mheon commented Jul 24, 2018

LGTM
@rh-atomic-bot r+

@rh-atomic-bot
Copy link
Collaborator

📌 Commit d3b945c has been approved by mheon

@rh-atomic-bot
Copy link
Collaborator

⌛ Testing commit d3b945c with merge fe0bd9d...

@rh-atomic-bot
Copy link
Collaborator

💔 Test failed - status-papr

@mheon
Copy link
Member

mheon commented Jul 24, 2018

Homu timeouts have returned

@rhatdan
Copy link
Member Author

rhatdan commented Jul 24, 2018

@rh-atomic-bot retry

@rh-atomic-bot
Copy link
Collaborator

⌛ Testing commit d3b945c with merge 153d338...

@rh-atomic-bot
Copy link
Collaborator

☀️ Test successful - status-papr
Approved by: mheon
Pushing 153d338 to master...

@rhatdan rhatdan deleted the mac-address branch December 1, 2022 22:03
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 19, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants