Cirrus: Reduce APIv2 task timeout #11372
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Note: The 10-minute runtime is a total guess based on my own memory/experience. It would be nice to confirm 20-minute timeout actually gives enough margin. |
|
LGTM |
|
update: I peeped at around a dozen recent runs across several branches. The worst-case for this task completing is just over 7-minutes. So the 20m timeout is probably fine, considering some margin for new tests and the odd-ball infrastructure slowdowns. |
|
/lgtm |
openshift-ci
bot
added
the
do-not-merge/hold
cevich
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
Ahh, lovely, see there, flake happened and proves 20-minute time is helpful 😁 |
|
Oof, this task fails a lot. I see somebody else is helping me smash the re-run button, thanks 😁 |
|
sigh more smashing the re-run button. I feel REALLY bad for all the other in-flight PRs right now, all waiting an hour 😢 Maybe should I make this a |
|
@baude @edsantiago @vrothberg would you be okay if we just merge this w/o passing tests? I've re-run the APIv2 test 9-times now. Every time I press re-run after 20-minutes, I sympathize with literally everybody else who has to wait a hour 😓 |
|
Did you rebase on top of main? We should have a fix for the APIv2 issue landed. |
|
Aw. I was having so much fun pressing re-run. |
At the time of this commit, a significant problem has been identified (introduced in f5ce02b). The effect is, `podman pull` has a chance of hanging, especially when re-pulling an existing image. While a fix is in the works, there's no reason to make developers wait the full (default) 1-hour timeout for the APIv2 task. Reduce it to 2x nominal test runtime, so if the hang/flake is hit, the task can be re-run more quickly. Signed-off-by: Chris Evich <[email protected]>
Hmmm, well crap, I was hoping for more of a party-balloons and confetti event. Okay, there we go, it's rebased now. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cevich, edsantiago The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
At the time of this commit, a significant problem has been identified
(introduced in f5ce02b). The effect is,
podman pullhas a chanceof hanging, especially when re-pulling an existing image. While a fix
is in the works, there's no reason to make developers wait the full
(default) 1-hour timeout for the APIv2 task. Reduce it to 2x nominal
test runtime, so if the hang/flake is hit, the task can be re-run more
quickly.
Signed-off-by: Chris Evich [email protected]