-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI:DOCS] fix indentation for userns modes #11368
Conversation
Closes: containers#11364 Signed-off-by: Giuseppe Scrivano <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM |
@giuseppe, could you repush? The deadlock is hitting us again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The auto options could also be indented to make it clear that they only belong to the auto keyword: |
Aha, I think the layout change was aiming to remove the outer bullet list (but forgot keep-id, ns and private) My preference would be a two-level bullet list: or alternatively to lift out the inner bullet list (i.e. the auto options) and put it as a separate section after the section that lists all --userns options. Something like this: |
Test failures, have nothing to do with this PR. Forcing merge. |
Closes: #11364
Signed-off-by: Giuseppe Scrivano [email protected]