container: resolve workdir during initialization after all the mounts are completed. #11353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flouthoc
changed the title
flouthoc
force-pushed
the
resolve-workdir-after-mounts
branch
from
582db60 to
20f3ced
Compare
openshift-ci
bot
added
the
approved
openshift-ci
bot
added
the
do-not-merge/hold
|
Can you add a test for this? |
flouthoc
force-pushed
the
resolve-workdir-after-mounts
branch
from
20f3ced to
a09d0a8
Compare
|
@Luap99 added a test: container run should fail if |
flouthoc
force-pushed
the
resolve-workdir-after-mounts
branch
from
a09d0a8 to
52e7eec
Compare
giuseppe
reviewed
Aug 30, 2021
flouthoc
force-pushed
the
resolve-workdir-after-mounts
branch
from
52e7eec to
a5bb17b
Compare
flouthoc
force-pushed
the
resolve-workdir-after-mounts
branch
from
a5bb17b to
3b9eaf9
Compare
There are use-cases where users would want to use overlay-mounts as workdir. For such cases workdir should be resolved after all the mounts are completed during the container init process. Signed-off-by: Aditya Rajan <[email protected]>
flouthoc
force-pushed
the
resolve-workdir-after-mounts
branch
from
3b9eaf9 to
ec1f350
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
LGTM |
openshift-ci
bot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are use-cases where users would want to use overlay-mounts as
workdir for containers. For such use-cases workdir should be resolved after all the mounts
are completed during the container init process.
Closes: #11352