Add support for mount options to API #11334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwhonce
added
kind/bug
openshift-ci
bot
added
the
approved
vrothberg
reviewed
Aug 27, 2021
|
|
||
| // Map any specialized mount options that intersect between *Options and cli options | ||
| switch m.Type { | ||
| case mount.TypeBind: |
There was a problem hiding this comment.
Could we use libpod/define instead?
There was a problem hiding this comment.
@vrothberg This is "more" type correct rather than falling back to go's lazy conversion of aliased types. define.TypeTmpfs is a string while mount.Type is an alias for string. I would rather keep this.
cdoern
reviewed
Aug 27, 2021
openshift-ci
bot
added
the
needs-rebase
mheon
reviewed
Aug 27, 2021
mheon
reviewed
Aug 27, 2021
openshift-ci
bot
removed
the
needs-rebase
When creating containers the specialized mount options where not populated via the API. Fixes: containers#10831 Signed-off-by: Jhon Honce <[email protected]>
|
/lgtm |
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jwhonce, mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating containers the specialized mount options where not
populated via the API.
Fixes: #10831
Signed-off-by: Jhon Honce [email protected]