Globally replace http:// with https:// #11333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
Luap99
requested changes
Aug 26, 2021
RELEASE_NOTES.md
Outdated
| @@ -948,7 +948,7 @@ | |||
| - Fixed a bug where the libpod and compat Build endpoints did not accept the `application/tar` content type (instead only accepting `application/x-tar`) ([#7185](https://github.com/containers/podman/issues/7185)). | |||
| - Fixed a bug where the libpod Exists endpoint would attempt to write a second header in some error conditions ([#7197](https://github.com/containers/podman/issues/7197)). | |||
| - Fixed a bug where compat and libpod Network Inspect and Network Remove endpoints would return a 500 instead of 404 when the requested network was not found. | |||
| - Added a versioned `_ping` endpoint (e.g. `http://localhost/v1.40/_ping`). | |||
| - Added a versioned `_ping` endpoint (e.g. `https://localhost/v1.40/_ping`). | |||
contrib/build_rpm.sh
Outdated
| @@ -16,7 +16,7 @@ gpgcheck=0" > /etc/yum.repos.d/container_virt.repo | |||
| name=paas_openshift_origin311 | |||
| # Use this if you need the newest *-testing packages | |||
| # baseurl=https://buildlogs.centos.org/centos/7/paas/x86_64/openshift-origin311/ | |||
| baseurl=http://mirror.centos.org/centos/7/paas/x86_64/openshift-origin311/ | |||
| baseurl=https://mirror.centos.org/centos/7/paas/x86_64/openshift-origin311/ | |||
There was a problem hiding this comment.
I don't think the mirror supports https
contrib/cirrus/logformatter
Outdated
| "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"> | ||
| <html xmlns="http://www.w3.org/1999/xhtml" lang="en-US"> | ||
| "https://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"> | ||
| <html xmlns="https://www.w3.org/1999/xhtml" lang="en-US"> |
contrib/msi/podman.wxs
Outdated
| @@ -1,5 +1,5 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <Wix xmlns="http://schemas.microsoft.com/wix/2006/wi"> | |||
| <Wix xmlns="https://schemas.microsoft.com/wix/2006/wi"> | |||
There was a problem hiding this comment.
@rhatdan Yeah, microsoft keeps moving them.
rhatdan
force-pushed
the
http-proxy
branch
5 times, most recently
from
ed811e7 to
f94d266
Compare
|
@Luap99 must smaller list now. |
|
Still lots of test redness. |
|
@rhatdan Because the API is wrapped in a ssh session for remote support, the API server currently doesn't have HTTPS configured. Seemed a waste of resources to encrypt an encrypted channel. |
[NO TESTS NEEDED] Hopefully existing tests will find issues. Signed-off-by: Daniel J Walsh <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[NO TESTS NEEDED] Hopefully existing tests will find issues.
Signed-off-by: Daniel J Walsh [email protected]