podman inspect show exposed ports #11314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@mheon PTAL |
mheon
reviewed
Aug 24, 2021
| // The map key is the port and the string slice contains the protocols, | ||
| // e.g. tcp and udp | ||
| // These are only set when exposed ports are given but not published. | ||
| ExposedPorts map[uint16][]string `json:"exposedPorts,omitempty"` |
There was a problem hiding this comment.
We should probably wire this into Commit, so the exposed ports are added to committed images. I'm actually kind of amazed this wasn't in before - had to double-check to make sure.
There was a problem hiding this comment.
Good call, they get commited now.
Podman inspect has to show exposed ports to match docker. This requires
storing the exposed ports in the container config.
A exposed port is shown as `"80/tcp": null` while a forwarded port is
shown as `"80/tcp": [{"HostIp": "", "HostPort": "8080" }]`.
Also make sure to add the exposed ports to the new image when the
container is commited.
Fixes containers#10777
Signed-off-by: Paul Holzinger <[email protected]>
|
LGTM |
|
Changes LGTM, but it looks like you may have a real test error. |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Podman inspect has to show exposed ports to match docker. This requires
storing the exposed ports in the container config.
A exposed port is shown as
"80/tcp": nullwhile a forwarded port isshown as
"80/tcp": [{"HostIp": "", "HostPort": "8080" }].Fixes #10777