profiling: higher memory sampling rate #11308
Conversation
openshift-ci
bot
added
the
approved
cmd/podman/root.go
Outdated
| } | ||
| } | ||
| if cmd.Flag("memory-profile").Changed { | ||
| // Same value as the default in github.com/pkg/profile. |
There was a problem hiding this comment.
Shouldn't there be a similar os.Create(cfs.MemoryProfile) be here as well?
There was a problem hiding this comment.
That's happening below in the pre-stop hook. The CPU profile is created at the beginning an continuously being written to while the memory profile is created at the very end with all samples.
There was a problem hiding this comment.
What happens if the file can not be created? I would prefer to know early rather then run my entire test and have it blow up in the end?
There was a problem hiding this comment.
It'll blow up at the end. There's not much we can do, since the memory profile must be written at the end. It's just how the stdlib wants it.
Note that the flag is hidden and meant to be only used by the devs.
|
/lgtm |
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mheon, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Increase the memory-sampling rate to the same default as github.com/pkg/profile. Allow for custom rates by reading the `MemProfileRate` env variable. [NO TESTS NEEDED] since it's a dev only flag and not part of CI. Signed-off-by: Valentin Rothberg <[email protected]>
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Increase the memory-sampling rate to the same default as
github.com/pkg/profile. Allow for custom rates by reading
the
MemProfileRateenv variable.Signed-off-by: Valentin Rothberg [email protected]
@mheon @baude PTAL