Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

teardown play kube #11298

Merged
merged 2 commits into from
Aug 26, 2021
Merged

teardown play kube #11298

merged 2 commits into from
Aug 26, 2021

Conversation

baude
Copy link
Member

@baude baude commented Aug 20, 2021

add the ability for play kube to tear down based on the yaml used to
play it. it is indicated by --down in the play kube command. volumes
are NOT deleted during the teardown. pods and their containers are
stopped and removed.

Signed-off-by: Brent Baude [email protected]

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 20, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2021
cmd/podman/play/kube.go Outdated Show resolved Hide resolved
cmd/podman/play/kube.go Show resolved Hide resolved
test/e2e/play_kube_test.go Show resolved Hide resolved
pkg/domain/infra/abi/play.go Show resolved Hide resolved
cmd/podman/play/kube.go Outdated Show resolved Hide resolved
cmd/podman/play/kube.go Show resolved Hide resolved
cmd/podman/play/kube.go Show resolved Hide resolved
pkg/api/handlers/libpod/play.go Outdated Show resolved Hide resolved
pkg/api/handlers/libpod/play.go Outdated Show resolved Hide resolved
pkg/api/handlers/libpod/play.go Outdated Show resolved Hide resolved
pkg/api/handlers/libpod/play.go Outdated Show resolved Hide resolved
pkg/api/server/register_play.go Outdated Show resolved Hide resolved
@baude baude force-pushed the kubeupdown branch 2 times, most recently from f115042 to 756d15c Compare August 24, 2021 19:22
add the ability for play kube to tear down based on the yaml used to
play it.  it is indicated by --down in the play kube command.  volumes
are NOT deleted during the teardown.  pods and their containers are
stopped and removed.

Signed-off-by: Brent Baude <[email protected]>
Add special case for op PlayKubeDownLibpod Heuristic for guessing swagger operation id too limited for PlayKubeDownLibpod

Signed-off-by: Jhon Honce <[email protected]>
@mheon
Copy link
Member

mheon commented Aug 26, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2021
@openshift-merge-robot openshift-merge-robot merged commit 94c37d7 into containers:main Aug 26, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants