volumes: Add support for `volume export` which allows exporting content to external path. #11290

flouthoc · 2021-08-20T08:59:11Z

Adds support for transferring data between systems and backing up systems via exporting volume content to external specified tar.
Use cases: Recover from disasters or move data between machines.

flouthoc · 2021-08-20T09:11:54Z

@mheon PTAL

Luap99 · 2021-08-20T09:16:23Z

cmd/podman/volumes/export.go

+
+Allow content of volume to be exported into external tar.`
+	exportCommand = &cobra.Command{
+		Use:               "export [options]",


This line is wrong

Suggested change

Use: "export [options]",

Use: "[options] VOLUME",

@Luap99 this is needed for correct formatting of podman volume --help.

Sorry, yes export has to stay my bad.

The VOLUME part is missing, this is causing the completion test to fail.

cmd/podman/volumes/export.go

test/e2e/volume_create_test.go

utils/utils.go

cmd/podman/volumes/export.go

docs/source/markdown/podman-volume-export.1.md

cmd/podman/volumes/export.go

openshift-ci · 2021-08-20T10:01:34Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

rhatdan · 2021-08-20T10:18:53Z

Once this feature is created, you will need to write a blog on it.

Are you planning podman volume import?

flouthoc · 2021-08-20T10:21:46Z

@rhatdan yes volume import is just after this.

flouthoc · 2021-08-20T10:56:43Z

@Luap99 @rhatdan could you please take a look again resolved all feedback points.

Luap99 · 2021-08-20T11:00:27Z

cmd/podman/volumes/export.go

+	flags := exportCommand.Flags()
+
+	outputFlagName := "output"
+	flags.StringVarP(&cliExportOpts.Output, outputFlagName, "o", "/dev/stdout", "Output=[path]")


Please do not use /dev/stdout as path. This will fail on windows. Actually looking at this this will not work with podman-remote at all, right? I think not supporting remote would be fine but we should disable this command on the remote cleint and document this.

I agree, no need for remote support.

@Luap99 Yes we cant have this on remote-client. Do you still think we should not use /dev/stdout ?

/dev/stdout is fine if we only support linux.

Look here how to disable to command on the remote client:

podman/cmd/podman/networks/reload.go

Line 18 in 7d8650c

Annotations: map[string]string{registry.EngineMode: registry.ABIMode},

@Luap99 linux or *nix. I disabled it via !registry.IsRemote().

Please use the Annotation and not use !registry.IsRemote() This should be consistent with the other commands.

@Luap99 Yes annotation seems cleaner switched to annotation, PTAL.

cmd/podman/volumes/export.go

flouthoc · 2021-08-22T11:41:19Z

@rhatdan @mheon added a check for unmounted volumes :). PTAL

rhatdan · 2021-08-23T14:20:47Z

LGTM
@Luap99 @mheon PTAL

pkg/domain/infra/abi/volumes.go

pkg/domain/infra/tunnel/volumes.go

Luap99

LGTM

libpod/volume.go

mheon · 2021-08-23T15:08:07Z

One last thing otherwise LGTM

Adds support for transferring data between systems and backing up systems. Use cases: recover from disasters or move data between machines. Signed-off-by: flouthoc <[email protected]>

mheon · 2021-08-23T18:00:34Z

/lgtm

flouthoc force-pushed the volume-export branch from ece50d3 to 5519bf4 Compare August 20, 2021 09:09

flouthoc force-pushed the volume-export branch from 5519bf4 to de8d25c Compare August 20, 2021 09:21

Luap99 reviewed Aug 20, 2021

View reviewed changes

flouthoc force-pushed the volume-export branch 3 times, most recently from e0c6d59 to c25d2ad Compare August 20, 2021 09:59

rhatdan approved these changes Aug 20, 2021

View reviewed changes

docs/source/markdown/podman-volume-export.1.md Outdated Show resolved Hide resolved

cmd/podman/volumes/export.go Outdated Show resolved Hide resolved

cmd/podman/volumes/export.go Show resolved Hide resolved

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2021

flouthoc force-pushed the volume-export branch from c25d2ad to 2580f8f Compare August 20, 2021 10:10

flouthoc force-pushed the volume-export branch from 2580f8f to 757d652 Compare August 20, 2021 10:20

flouthoc force-pushed the volume-export branch 3 times, most recently from 23791da to 33370b2 Compare August 20, 2021 10:51

flouthoc requested review from Luap99 and rhatdan August 20, 2021 10:56

Luap99 reviewed Aug 20, 2021

View reviewed changes

flouthoc force-pushed the volume-export branch from 33370b2 to 03fb246 Compare August 20, 2021 11:20

flouthoc requested a review from Luap99 August 20, 2021 11:21

flouthoc force-pushed the volume-export branch 3 times, most recently from be0c5a6 to a11850b Compare August 20, 2021 12:03

mheon reviewed Aug 20, 2021

View reviewed changes

cmd/podman/volumes/export.go Show resolved Hide resolved

flouthoc force-pushed the volume-export branch 3 times, most recently from 375b7fa to 446c0bc Compare August 20, 2021 19:57

flouthoc force-pushed the volume-export branch 2 times, most recently from 7c34dd1 to fde9ce7 Compare August 22, 2021 07:48

flouthoc requested a review from mheon August 22, 2021 11:41

flouthoc mentioned this pull request Aug 23, 2021

volumes: Add support for volume import which allows importing contents of external tarballs into podman volumes. #11307

Merged

Luap99 reviewed Aug 23, 2021

View reviewed changes

pkg/domain/infra/abi/volumes.go Outdated Show resolved Hide resolved

pkg/domain/infra/tunnel/volumes.go Outdated Show resolved Hide resolved

flouthoc force-pushed the volume-export branch from fde9ce7 to 86803e2 Compare August 23, 2021 14:55

flouthoc requested a review from Luap99 August 23, 2021 14:56

Luap99 reviewed Aug 23, 2021

View reviewed changes

mheon reviewed Aug 23, 2021

View reviewed changes

libpod/volume.go Show resolved Hide resolved

volumes: Add support for exporting volumes to external tar

edddfe8

Adds support for transferring data between systems and backing up systems. Use cases: recover from disasters or move data between machines. Signed-off-by: flouthoc <[email protected]>

flouthoc force-pushed the volume-export branch from 86803e2 to edddfe8 Compare August 23, 2021 15:13

flouthoc requested review from mheon and Luap99 August 23, 2021 15:14

openshift-ci bot assigned mheon Aug 23, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2021

openshift-merge-robot merged commit 90cf78b into containers:main Aug 23, 2021

github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023

github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

volumes: Add support for `volume export` which allows exporting content to external path. #11290

volumes: Add support for `volume export` which allows exporting content to external path. #11290

flouthoc commented Aug 20, 2021

flouthoc commented Aug 20, 2021

Luap99 Aug 20, 2021

flouthoc Aug 20, 2021

Luap99 Aug 20, 2021

Luap99 Aug 20, 2021

openshift-ci bot commented Aug 20, 2021

rhatdan commented Aug 20, 2021

flouthoc commented Aug 20, 2021

flouthoc commented Aug 20, 2021

Luap99 Aug 20, 2021

rhatdan Aug 20, 2021

flouthoc Aug 20, 2021

Luap99 Aug 20, 2021

flouthoc Aug 20, 2021

Luap99 Aug 20, 2021

flouthoc Aug 20, 2021

flouthoc commented Aug 22, 2021

rhatdan commented Aug 23, 2021

Luap99 left a comment

mheon commented Aug 23, 2021

mheon commented Aug 23, 2021

volumes: Add support for volume export which allows exporting content to external path. #11290

volumes: Add support for volume export which allows exporting content to external path. #11290

Conversation

flouthoc commented Aug 20, 2021

flouthoc commented Aug 20, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

openshift-ci bot commented Aug 20, 2021

rhatdan commented Aug 20, 2021

flouthoc commented Aug 20, 2021

flouthoc commented Aug 20, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

flouthoc commented Aug 22, 2021

rhatdan commented Aug 23, 2021

Luap99 left a comment

Choose a reason for hiding this comment

mheon commented Aug 23, 2021

mheon commented Aug 23, 2021

volumes: Add support for `volume export` which allows exporting content to external path. #11290

volumes: Add support for `volume export` which allows exporting content to external path. #11290