machine: compute sha256 as we are reading the file #11279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude, guillaumerose The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
baude
reviewed
Aug 19, 2021
pkg/machine/fcos.go
Outdated
| return true, nil | ||
| } | ||
| } | ||
| defer fd.Close() |
There was a problem hiding this comment.
can you catch the error and use logrus to dump it?
|
lgtm, just the one suggestion |
[NO TESTS NEEDED] Signed-off-by: Guillaume Rose <[email protected]>
It avoids to have the full file in memory. [NO TESTS NEEDED] Signed-off-by: Guillaume Rose <[email protected]>
guillaumerose
force-pushed
the
refactor1
branch
from
abab5fe to
b19812b
Compare
|
/lgtm Nice work! |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
small refactoring that can help a bit.