Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gvproxy path search for macos #11234

Merged
merged 1 commit into from
Aug 16, 2021
Merged

Conversation

baude
Copy link
Member

@baude baude commented Aug 16, 2021

macos does not have /usr/libexec/ so we look in the executable paths
first.

Fixes: #11226

Signed-off-by: Brent Baude [email protected]

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2021
macos does not have /usr/libexec/ so we look in the executable paths
first.

Fixes: containers#11226

[NO TESTS NEEDED]

Signed-off-by: Brent Baude <[email protected]>
@baude baude force-pushed the v3.3fixmacospath branch from 30d534c to 440188f Compare August 16, 2021 15:03
@rhatdan
Copy link
Member

rhatdan commented Aug 16, 2021

LGTM

@mheon
Copy link
Member

mheon commented Aug 16, 2021

/approve
/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 16, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2021
@baude
Copy link
Member Author

baude commented Aug 16, 2021

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 16, 2021
@openshift-ci openshift-ci bot merged commit 39cab79 into containers:v3.3 Aug 16, 2021
@baude baude deleted the v3.3fixmacospath branch May 18, 2022 15:17
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants