Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename oneshot initcontainers to once #11219

Merged
merged 1 commit into from
Aug 15, 2021

Conversation

baude
Copy link
Member

@baude baude commented Aug 12, 2021

after the init containers pr merged, it was suggested to use once
instead of oneshot containers as it is more aligned with other
terminology used similarly.

[NO TESTS NEEDED]

Signed-off-by: Brent Baude [email protected]

after the init containers pr merged, it was suggested to use `once`
instead of `oneshot` containers as it is more aligned with other
terminiology used similarily.

[NO TESTS NEEDED]

Signed-off-by: Brent Baude <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 12, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2021
@rhatdan
Copy link
Member

rhatdan commented Aug 12, 2021

LGTM
But tests are not happy.

@TomSweeneyRedHat
Copy link
Member

LGTM
once tests are hip, I restarted the failing test, I can't imagine it was failing due to this change.

@rhatdan
Copy link
Member

rhatdan commented Aug 15, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2021
@openshift-ci openshift-ci bot merged commit 5592ac9 into containers:main Aug 15, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants