Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run codespell to fix spelling #11203

Merged
merged 1 commit into from
Aug 12, 2021
Merged

Run codespell to fix spelling #11203

merged 1 commit into from
Aug 12, 2021

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Aug 11, 2021

[NO TESTS NEEDED] Just fixing spelling.

Signed-off-by: Daniel J Walsh [email protected]

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2021
Luap99
Luap99 reviewed Aug 11, 2021
View reviewed changes
completions/powershell/podman-remote.ps1 Outdated
@@ -216,7 +216,7 @@ Register-ArgumentCompleter -CommandName 'podman-remote' -ScriptBlock {
Default {
# Like MenuComplete but we don't want to add a space here because
# the user need to press space anyway to get the completion.
# Description will not be shown because thats not possible with TabCompleteNext
# Description will not be shown because that's not possible with TabCompleteNext
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this. The completion files are auto generated with cobra.

completions/powershell/podman.ps1 Outdated
@@ -216,7 +216,7 @@ Register-ArgumentCompleter -CommandName 'podman' -ScriptBlock {
Default {
# Like MenuComplete but we don't want to add a space here because
# the user need to press space anyway to get the completion.
# Description will not be shown because thats not possible with TabCompleteNext
# Description will not be shown because that's not possible with TabCompleteNext
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove ps1 from codespell processing.

@baude
Copy link
Member

baude commented Aug 11, 2021

LGTM

@edsantiago
Copy link
Member

Oh sweet, the completions check worked:

tree is dirty, please run 'make completions' and commit all changes

 M completions/powershell/podman-remote.ps1
 M completions/powershell/podman.ps1

edsantiago
edsantiago reviewed Aug 11, 2021
View reviewed changes
test/system/255-auto-update.bats Outdated
@@ -305,7 +305,7 @@ EOF
fi
done

# Only check the last service is started. Previous services should already actived.
# Only check the last service is started. Previous services should already activated.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neither of these make sense. Maybe "already be" activated"? And, I dislike the word "should": it's ambiguous, sometimes meaning "we expect that", and sometimes meaning "we will take care of it". How about:

# Check that only the last service is started; previous services have been activated elsewhere

(but even that is cringy. I don't have a good sense for what is being tested here).

@edsantiago
Copy link
Member

@rhatdan I think you accidentally included vendor commits

@rhatdan
Run codespell to fix spelling
404488a 
[NO TESTS NEEDED] Just fixing spelling.

Signed-off-by: Daniel J Walsh <[email protected]>
@jwhonce
Copy link
Member

jwhonce commented Aug 11, 2021

/hold
/lgtm

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 11, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2021
@Luap99
Copy link
Member

Luap99 commented Aug 12, 2021

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 12, 2021
@openshift-ci openshift-ci bot merged commit de043a5 into containers:main Aug 12, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Luap99 Luap99 Luap99 left review comments

@edsantiago edsantiago edsantiago left review comments

Assignees

@jwhonce jwhonce

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rhatdan @baude @edsantiago @jwhonce @Luap99