[CI:DOCS] Document source ip for the rootlesskit port handler #11177
Conversation
openshift-ci
bot
added
the
approved
| @@ -678,7 +678,8 @@ Valid _mode_ values are: | |||
| - **outbound_addr6=INTERFACE**: Specify the outbound interface slirp should bind to (ipv6 traffic only). | |||
| - **outbound_addr6=IPv6**: Specify the outbound ipv6 address slirp should bind to. | |||
| - **port_handler=rootlesskit**: Use rootlesskit for port forwarding. Default. | |||
| - **port_handler=slirp4netns**: Use the slirp4netns port forwarding. | |||
| Note: Rootlesskit changes the source ip of incoming packets to a IP in the container network namespace, usually `10.0.2.100`. If your application requires the real source ip, e.g. web server logs, use the slirp4netns port handler. This port handler is also used for rootless users when connected to user-defined networks. | |||
There was a problem hiding this comment.
This port handler is also used for rootless users when connected to user-defined networks.
Perhaps "rootless users" -> "rootless containers"
There was a problem hiding this comment.
Also, "This port handler" -> "RootlessKit port handler" might be better. (Some people may interpret "this" to be slirp4netns that is mentioned in the previous sentence)
There was a problem hiding this comment.
nit: "ip" -> "IP address"
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AkihiroSuda, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| - **bridge**: create a network stack on the default bridge; | ||
| - **none**: no networking; | ||
| - **host**: use the Podman host network stack. Note: the host mode gives the container full access to local system services such as D-bus and is therefore considered insecure; | ||
| - **network**: connect to a user-defined network, multiple networks should be comma-separated; |
There was a problem hiding this comment.
I copied this from podman create. I can remove the semi colons everywhere if you want.
|
lgtm other than the nit |
|
Semicolon removal seems like a good idea, otherwise LGTM |
Also add some missing options to podman pod create. Fixes containers#10884 Signed-off-by: Paul Holzinger <[email protected]>
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Fixes #10884