Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable docker-py compat. testing w/ ignored result #11169

Merged
merged 1 commit into from
Aug 16, 2021
Merged

Enable docker-py compat. testing w/ ignored result #11169

merged 1 commit into from
Aug 16, 2021

Conversation

cevich
Copy link
Member

@cevich cevich commented Aug 9, 2021

Partially address #9229

Significant bitrot results in almost immediate test failure. This
commit adds only the very basic, bare-minimum needed to get them
started directly on the host.

TESTING RESULTS ARE IGNORED

@cevich cevich requested a review from jwhonce August 9, 2021 19:27
@cevich cevich force-pushed the enable_docker_py_testing branch 2 times, most recently from 1515c3c to 3805094 Compare August 9, 2021 20:04
jwhonce
jwhonce requested changes Aug 9, 2021
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@TomSweeneyRedHat
Copy link
Member

LGTM assuming @jwhonce 's comment is addressed.

@cevich cevich force-pushed the enable_docker_py_testing branch from 3805094 to b150c89 Compare August 9, 2021 20:18
@cevich cevich force-pushed the enable_docker_py_testing branch from b150c89 to 522dfb8 Compare August 9, 2021 20:43
@cevich cevich changed the title Enable docker-py compat. testing w/ ignored result [WIP] Enable docker-py compat. testing w/ ignored result Aug 9, 2021
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 9, 2021
@cevich cevich force-pushed the enable_docker_py_testing branch from 522dfb8 to a32d3c0 Compare August 9, 2021 21:16
@cevich
Enable docker-py compat. testing w/ ignored result
2744366 
Significant bitrot results in almost immediate test failure.  This
commit adds only the very basic, bare-minimum needed to get them
started.

***TESTING RESULTS ARE IGNORED***

Signed-off-by: Chris Evich <[email protected]>
@cevich cevich force-pushed the enable_docker_py_testing branch from a32d3c0 to 2744366 Compare August 9, 2021 21:33
@cevich cevich changed the title [WIP] Enable docker-py compat. testing w/ ignored result Enable docker-py compat. testing w/ ignored result Aug 9, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 9, 2021
@cevich cevich requested a review from jwhonce August 11, 2021 17:03
@jwhonce jwhonce marked this pull request as draft August 11, 2021 20:40
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 11, 2021
@edsantiago
Copy link
Member

Eek. This is beyond my ability to review, it's more pythony than what I know. If it passes CI -- and it seems to have -- it LGTM.

I think the original issue was asking for a way to run these tests from the command line, though? Is there a way to do that? Do we even want to?

@cevich
Copy link
Member Author

cevich commented Aug 12, 2021

I think the original issue was asking for a way to run these tests from the command line, though? Is there a way to do that? Do we even want to?

Eventually, this would be nice for any developers wanting to work on it away from CI. Jhon and I chatted and we think this can be left up to a future PR.

@cevich cevich marked this pull request as ready for review August 12, 2021 21:14
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 12, 2021
@cevich
Copy link
Member Author

cevich commented Aug 16, 2021

I think the original issue was

In the interest of transparency, I'm not expecting merge of this PR to close #9229. A large part of getting this task working was about environment setup. So my intention is to open a new PR to handle the "running from Makefile" issue, now that the needed environment is a known-quantity.

@rhatdan
Copy link
Member

rhatdan commented Aug 16, 2021

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2021
@openshift-ci openshift-ci bot merged commit 26b1ddd into containers:main Aug 16, 2021
@cevich cevich deleted the enable_docker_py_testing branch April 18, 2023 14:44
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Aug 31, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jwhonce jwhonce Awaiting requested review from jwhonce

Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cevich @TomSweeneyRedHat @edsantiago @rhatdan @jwhonce