[V3.3] Update images #11163
Merged
[V3.3] Update images #11163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
/approve |
openshift-ci
bot
added
the
approved
rhatdan
reviewed
Aug 9, 2021
|
/approve |
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cevich, mheon, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Note: I'm going to hold of updating this PR, since the test fixes are so similar to #10829 |
cevich
force-pushed
the
v3.3_update_images
branch
from
9128c55 to
bf23b48
Compare
cevich
force-pushed
the
v3.3_update_images
branch
2 times, most recently
from
346005b to
0b00a2f
Compare
openshift-ci
bot
added
the
needs-rebase
cevich
force-pushed
the
v3.3_update_images
branch
from
0b00a2f to
af4db42
Compare
openshift-ci
bot
removed
the
needs-rebase
Previously we were generating the annotated results but never uploading them. Fix this so visiting the advertised URL actually works. Signed-off-by: Chris Evich <[email protected]>
Ref: containers#11165 Signed-off-by: Chris Evich <[email protected]>
This test has been failing for a long time but nobody noticed because CI doesn't have the device node (nested-VM support was disabled). After having enabled nested VM support, tests fail due to some unknown special-handling of this device. Fix both problems by removing the `skip()` and switching to a more generic device which is only present when `--privileged` is used. Signed-off-by: Chris Evich <[email protected]>
Update test to confirm the negative-case, proving the `--privileged` "option is required" for this character device to be present in a container (including rootless). Signed-off-by: Chris Evich <[email protected]>
The `ls` command is not intended for this purpose and may behave in unexpected ways, leading to false positive or negative results. Update the tests to use the purpose built `test` command instead. Also added several *TODO* comments for possible future testing enhancements. Signed-off-by: Chris Evich <[email protected]>
This reverts commit 404d5ed. The replacement (updated) images include a fix for: containers/common#631 Also minor update to an unrelated FIXME comment. Signed-off-by: Chris Evich <[email protected]>
Ref: containers#10829 (comment) Signed-off-by: Chris Evich <[email protected]>
This becomes a problem on hosts with upgraded policies. Ref: containers#10522 Also, made a small change to compose-test setup to reduce runtime. Signed-off-by: Chris Evich <[email protected]>
These tests were originally enabled in a situation where CI provided false-positive results. Now that has been corrected, these tests all fail under a CGv1 container environment with the error: ``` Error: unable to load cgroup at /machine.slice/libpod-e4f...086.scope/libpod_parent/libpod-fbd...425: cgroup deleted ``` This commit simply disables the tests under this specific environment. Signed-off-by: Chris Evich <[email protected]>
cevich
force-pushed
the
v3.3_update_images
branch
from
1d70e88 to
a92441e
Compare
|
IMPORTANT: I'm okay if this PR merges before #10829 (to help with release timelines) however it makes me nervous. OTOH, the tests are passing, so 🤷♂️ |
Merged
|
LGTM |
|
/lgtm |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #10829 for the
v3.3branchDepends on: #11164, #11166