Reproducible Builds: trim embedded cgo paths

[kpcyrd]

The Arch Linux reproducible builds setup currently fails to reproduce podman (diff). The relevant part in the diff is:

│ │ ├── strings --all --bytes=8 {}
│ │ │ @@ -1,9 +1,9 @@
│ │ │  /lib64/ld-linux-x86-64.so.2
│ │ │ -fDMoJcLZqojBJnlXadN9/no_IKXu28dGv-5kgjWUm/HSPy4nrzjaE7jAmxaDUT/06FhXFIFJ4FwF81sy8x_
│ │ │ +CIrZsC53vVGulPBnzvSY/P_VErASmHt8np5NCPDQ8/LcpPc2AxUJaJ-MAKOAvh/xHYbWCnqxFpRwLK2eL7s
│ │ │  -*m4ibT|
│ │ │  _ITM_deregisterTMCloneTable
│ │ │  _ITM_registerTMCloneTable
│ │ │  pthread_mutexattr_setrobust
│ │ │  pthread_mutex_consistent
│ │ │  pthread_mutex_init
│ │ │  pthread_cond_wait
│ │ │ @@ -78810,15 +78810,15 @@
│ │ │  go/src/net/sockopt_posix.go
│ │ │  go/src/net/splice_linux.go
│ │ │  go/src/net/tcpsock_posix.go
│ │ │  go/src/net/tcpsockopt_posix.go
│ │ │  go/src/net/tcpsockopt_unix.go
│ │ │  go/src/net/udpsock_posix.go
│ │ │  go/src/net/unixsock_posix.go
│ │ │ -/tmp/go-build3474806368/b051/_cgo_gotypes.go
│ │ │ +/tmp/go-build3959924547/b051/_cgo_gotypes.go
│ │ │  go/src/net/cgo_resnew.go
│ │ │  go/src/net/cgo_unix.go
│ │ │  go/src/net/cgo_socknew.go
│ │ │  go/src/net/hook.go
│ │ │  go/src/net/hook_unix.go
│ │ │  go/src/net/url/url.go
│ │ │  go/src/crypto/dsa/dsa.go
│ │ │ @@ -78961,15 +78961,15 @@
│ │ │  go/src/strconv/atob.go
│ │ │  vendor/github.com/BurntSushi/toml/parse.go
│ │ │  vendor/github.com/BurntSushi/toml/type_check.go
│ │ │  vendor/github.com/BurntSushi/toml/type_fields.go
│ │ │  vendor/github.com/containers/image/v5/internal/rootless/rootless.go
│ │ │  go/src/os/user/lookup.go
│ │ │  go/src/os/user/user.go
│ │ │ -/tmp/go-build3474806368/b159/_cgo_gotypes.go
│ │ │ +/tmp/go-build3959924547/b159/_cgo_gotypes.go
│ │ │  go/src/os/user/cgo_lookup_unix.go
│ │ │  vendor/github.com/syndtr/gocapability/capability/capability.go
│ │ │  vendor/github.com/syndtr/gocapability/capability/capability_linux.go
│ │ │  vendor/github.com/syndtr/gocapability/capability/enum.go
│ │ │  vendor/github.com/syndtr/gocapability/capability/enum_gen.go
│ │ │  vendor/github.com/syndtr/gocapability/capability/syscall_linux.go
│ │ │  vendor/github.com/docker/go-units/duration.go
[...]

To fix the cgo paths, -trimpath needs to be passed in $GOFLAGS instead of -gcflags and -asmflags. This automatically resolves the other issues shown in the diff too. For more info on -trimpath with cgo see golang/go#47256.

Thanks!

cc: @Foxboron

[NO TESTS NEEDED]

[rhatdan]

You need to sign your commits.

git commit -a --amend -s
git push --force

You should also add [NO TESTS NEEDED] to your PR to avoid the next check.

[kpcyrd]

Done. I'm not sure why the tests are failing but I've added [NO TESTS NEEDED].

Thanks!

[rhatdan]

Your PR is still not signed.

[kpcyrd]

The commit was signed but I never added my pgp key to my github account.

I've added the key, can you check again?

[rhatdan]

The problem is the commit message needs to have a line like

Signed-off-by: Daniel J Walsh [email protected]

[kpcyrd]

Done!

[rhatdan]

LGTM
@containers/podman-maintainers PTAL
@mheon PTAL

[mheon]

I'd like a review from @lsm5 before merge, but LGTM

[saschagrunert]

LGTM

[lsm5]

LGTM

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kpcyrd, lsm5, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[lsm5]

/lgtm

[kpcyrd]

Thanks!