Libpod images pull changes

[cdoern]

Added quiet param to docs to limit stream output. Formatted JSON.

This is a breaking change for podman 4.0 as it changes the output of the libpod API, but I believe this makes it function more similarly to native podman pull.

fixes #10612

Signed-off-by: cdoern [email protected]

[TomSweeneyRedHat]

Changes LGTM, but tests aren't buying them

[cdoern]

@TomSweeneyRedHat strange, it was failing the images pull bindings test because it was returning 0 images instead of 1 even though it found the image... Possible it was a flake, I added an integration test as well to check quiet, will see if it fails again

[jwhonce]

@cdoern Why cache pull output vs. streaming it to client? What is the benefit? You are increasing the amount of memory needed by server and breaking API.

[cdoern]

@jwhonce main reason for caching it was for the --quiet flag, so user can still see what was streamed but not as a live thread. I can just take it out all together and --quiet removes all mentions of stream?

[rhatdan]

SGTM

[cdoern]

@rhatdan @jwhonce does failing test look like a flake? most of the fails on on play kube which doesn't make much sense to me why that would be failing. But it has a failed a few times now.

[jwhonce]

/lgtm

[mheon]

/approve
LGTM

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cdoern, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mheon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment