Alias build to buildx, so it won't fail #11134

rhatdan · 2021-08-04T19:06:29Z

Signed-off-by: Daniel J Walsh [email protected]

openshift-ci · 2021-08-04T19:06:32Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

rhatdan · 2021-08-04T19:06:41Z

Partially fixes #11130

edsantiago · 2021-08-04T19:42:35Z

test/system/070-build.bats

+FROM $IMAGE
+RUN echo $rand_content > /$rand_filename
+EOF
+


Shouldn't there be a run_podman buildx ... here?

a little heavy on the cut and pasting.

baude · 2021-08-04T20:07:34Z

lgtm

edsantiago · 2021-08-04T20:35:16Z

My only concern, and I say this as someone who has no clue what buildx is, is: what will happen when podman buildx gets implemented as its own command? What incompatibilities are there between build & buildx, that we will pay for because someone has written a script that does podman buildx --foo --bar, relying on --foo --bar from current podman build, that will break because those options don't exist or do something different in real-buildx?

rhatdan · 2021-08-04T20:46:12Z

We don't plan on adding buildx, only some of the options. But understand your point that their could be an option for
podman build --foo
which is different then
podman buildx --foo.

markusthoemmes · 2021-08-05T07:38:01Z

cmd/podman/images/build.go

@@ -44,6 +44,7 @@ var (
 	// Command: podman _diff_ Object_ID
 	buildDescription = "Builds an OCI or Docker image using instructions from one or more Containerfiles and a specified build context directory."
 	buildCmd         = &cobra.Command{
+		Aliases:           []string{"buildx"},


I think the alias should be buildx build (buildx has other subcommands) so when building an image with docker, one would call docker buildx build ...

Yes it has to be podman buildx build, other buildx subcommands should raise an error, see https://docs.docker.com/buildx/working-with-buildx/.

TomSweeneyRedHat · 2021-08-05T23:54:28Z

docs/source/markdown/podman-build.1.md

@@ -43,6 +43,8 @@ containers can be left in container storage. Use the `podman ps --all --storage`
 command to see these containers. External containers can be removed with the
 `podman rm --storage` command.

+`podman buildx` command is an alias of `podman build`.  Not all `buildx` features are available in Podman. The `buildx` option is provided for scripting compatibility.


Suggested change

`podman buildx` command is an alias of `podman build`. Not all `buildx` features are available in Podman. The `buildx` option is provided for scripting compatibility.

The `podman buildx` command is an alias of `podman build`. Not all `buildx` features are available in Podman. The `buildx` option is provided strictly for scripting compatibility.

rhatdan · 2021-08-06T15:25:56Z

@Luap99 could you take a look at the failures, seems to be some command completion problem?

Luap99

The test is broken, this diff should make it work:

diff --git a/cmd/podman/shell_completion_test.go b/cmd/podman/shell_completion_test.go
index 9bd821d8d..792beeb19 100644
--- a/cmd/podman/shell_completion_test.go
+++ b/cmd/podman/shell_completion_test.go
@@ -33,7 +33,9 @@ func TestShellCompletionFunctions(t *testing.T) {
 func checkCommand(t *testing.T, cmd *cobra.Command) {
        if cmd.HasSubCommands() {
                for _, childCmd := range cmd.Commands() {
-                       checkCommand(t, childCmd)
+                       if !childCmd.Hidden {
+                               checkCommand(t, childCmd)
+                       }
                }
 
                // if not check if completion for that command is provided

Luap99 · 2021-08-06T15:30:37Z

cmd/podman/images/buildx.go

+var (
+	// Command: podman _buildx_
+	// This is a hidden command, which was added to make converting
+	// from Docekr to Podman easier.


typo Docker

@Luap99 aotocompletion tests are still not happy.

rhatdan · 2021-08-06T15:40:38Z

Thanks @Luap99

TomSweeneyRedHat · 2021-08-07T00:46:56Z

@rhatdan test still aren't hip with this one.

afbjorklund · 2021-08-07T07:59:39Z

@edsantiago "buildx" means to build using BuildKit, normally implemented as a CLI plugin

It has a lot of subcommands, the usual one being build (which works as docker build)

Luap99 · 2021-08-09T08:11:15Z

cmd/podman/images/build.go

@@ -90,12 +90,20 @@ func init() {
 		Command: imageBuildCmd,
 		Parent:  imageCmd,
 	})
+	registry.Commands = append(registry.Commands, registry.CliCommand{
+		Command: imageBuildCmd,
+		Parent:  buildxCmd,


You have to create a separate command struct for buildx build. Do not reuse the imageBuildStruct. Cobra is not really designed to use the same command on several subcommands. Right now the use line in podman image build --help will show podman buildx build [options] [CONTEXT] instead of podman image build [options] [CONTEXT]. I think this is causing the other completion test to fail.

markusthoemmes · 2021-08-09T13:18:23Z

Seeing as this seems to interfere quite a bit with cobra and how the help text is shown, I wonder if we should consider moving the "compatibility" layer to the docker script as initially proposed. It feels like that'd reduce the collateral damage area to the docker domain (where one could argue, it should live).

Any thoughts on that @rhatdan? I'm very green behind my podman ears so that might be total bogus as well 😂

rhatdan · 2021-08-09T15:59:42Z

Hopefully this one will work, I attempted the failing tests locally and it passed.

Luap99

LGTM

Add hidden --load and --progress flag as well. Signed-off-by: Daniel J Walsh <[email protected]>

TomSweeneyRedHat · 2021-08-09T20:08:20Z

LGTM

TomSweeneyRedHat · 2021-08-09T20:08:26Z

/lgtm

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2021

rhatdan force-pushed the buildx branch from 66418e5 to 0b2f877 Compare August 4, 2021 19:07

edsantiago reviewed Aug 4, 2021

View reviewed changes

rhatdan force-pushed the buildx branch from 0b2f877 to fb5055f Compare August 4, 2021 19:47

markusthoemmes reviewed Aug 5, 2021

View reviewed changes

TomSweeneyRedHat reviewed Aug 5, 2021

View reviewed changes

rhatdan force-pushed the buildx branch from fb5055f to 6cf53ed Compare August 6, 2021 14:38

Luap99 reviewed Aug 6, 2021

View reviewed changes

rhatdan force-pushed the buildx branch from 6cf53ed to 772d159 Compare August 6, 2021 15:40

Luap99 reviewed Aug 9, 2021

View reviewed changes

This comment has been minimized.

Sign in to view

rhatdan force-pushed the buildx branch from 772d159 to 6e3db8b Compare August 9, 2021 15:47

Luap99 reviewed Aug 9, 2021

View reviewed changes

Alias build to buildx, so it won't fail

170fb25

Add hidden --load and --progress flag as well. Signed-off-by: Daniel J Walsh <[email protected]>

rhatdan force-pushed the buildx branch from 6e3db8b to 170fb25 Compare August 9, 2021 17:05

openshift-ci bot assigned TomSweeneyRedHat Aug 9, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2021

openshift-ci bot merged commit 6513add into containers:main Aug 9, 2021

edsantiago mentioned this pull request Aug 10, 2021

podman run --cgroups=disabled: missing "supervisor" #11191

Closed

markusthoemmes mentioned this pull request Nov 5, 2021

Make the docker buildx check call --help kubernetes/kubernetes#106174

Merged

github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023

github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Alias build to buildx, so it won't fail #11134

Alias build to buildx, so it won't fail #11134

rhatdan commented Aug 4, 2021

openshift-ci bot commented Aug 4, 2021

rhatdan commented Aug 4, 2021

edsantiago Aug 4, 2021

rhatdan Aug 4, 2021

baude commented Aug 4, 2021

edsantiago commented Aug 4, 2021

rhatdan commented Aug 4, 2021

markusthoemmes Aug 5, 2021

Luap99 Aug 5, 2021

TomSweeneyRedHat Aug 5, 2021

rhatdan commented Aug 6, 2021

Luap99 left a comment

Luap99 Aug 6, 2021

rhatdan Aug 6, 2021

rhatdan Aug 7, 2021

rhatdan commented Aug 6, 2021

TomSweeneyRedHat commented Aug 7, 2021

afbjorklund commented Aug 7, 2021

Luap99 Aug 9, 2021

markusthoemmes commented Aug 9, 2021

This comment has been minimized.

rhatdan commented Aug 9, 2021

Luap99 left a comment

TomSweeneyRedHat commented Aug 9, 2021

TomSweeneyRedHat commented Aug 9, 2021

	`podman buildx` command is an alias of `podman build`. Not all `buildx` features are available in Podman. The `buildx` option is provided for scripting compatibility.
	The `podman buildx` command is an alias of `podman build`. Not all `buildx` features are available in Podman. The `buildx` option is provided strictly for scripting compatibility.

Alias build to buildx, so it won't fail #11134

Alias build to buildx, so it won't fail #11134

Conversation

rhatdan commented Aug 4, 2021

openshift-ci bot commented Aug 4, 2021

rhatdan commented Aug 4, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

baude commented Aug 4, 2021

edsantiago commented Aug 4, 2021

rhatdan commented Aug 4, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rhatdan commented Aug 6, 2021

Luap99 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rhatdan commented Aug 6, 2021

TomSweeneyRedHat commented Aug 7, 2021

afbjorklund commented Aug 7, 2021

Choose a reason for hiding this comment

markusthoemmes commented Aug 9, 2021

This comment has been minimized.

rhatdan commented Aug 9, 2021

Luap99 left a comment

Choose a reason for hiding this comment

TomSweeneyRedHat commented Aug 9, 2021

TomSweeneyRedHat commented Aug 9, 2021