Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle timezone on server containers.conf #11128

Merged
merged 1 commit into from
Aug 4, 2021
Merged

Handle timezone on server containers.conf #11128

merged 1 commit into from
Aug 4, 2021

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Aug 4, 2021

Fixes: #11124

Signed-off-by: Daniel J Walsh [email protected]

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2021
vrothberg
vrothberg reviewed Aug 4, 2021
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@containers/podman-maintainers PTAL

Luap99
Luap99 reviewed Aug 4, 2021
View reviewed changes
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 4, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2021
saschagrunert
saschagrunert approved these changes Aug 4, 2021
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 4, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [rhatdan,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saschagrunert
Copy link
Member

Ou, the integration test does not seem to be happy:

[+1614s] output: host: arch: amd64 buildahVersion: 1.22.0-dev cgroupControllers: - cpuset - cpu - io - memory - hugetlb - pids cgroupManager: systemd cgroupVersion: v2 conmon: package: 'conmon: /usr/libexec/podman/conmon' path: /usr/libexec/podman/conmon version: 'conmon version 2.0.27, commit: ' cpus: 2 distribution: distribution: ubuntu version: "21.04" eventLogger: journald hostname: cirrus-task-4669329217159168 idMappings: gidmap: null uidmap: null kernel: 5.11.0-1007-gcp linkmode: dynamic memFree: 2382647296 memTotal: 4114534400 ociRuntime: name: crun package: 'crun: /usr/bin/crun' path: /usr/bin/crun version: |- crun version 0.19.1.3-9b83-dirty commit: 33851ada2cc9bf3945915565bf3c2df97facb92c spec: 1.0.0 +SYSTEMD +SELINUX +APPARMOR +CAP +SECCOMP +EBPF +CRIU +YAJL os: linux remoteSocket: exists: true path: /run/podman/podman-b6f1db3888ee0f06eff69ac7904dce01a22a3873f3b009eefd4c263e87dc19c9.sock security: apparmorEnabled: true capabilities: CAP_CHOWN,CAP_DAC_OVERRIDE,CAP_FOWNER,CAP_FSETID,CAP_KILL,CAP_NET_BIND_SERVICE,CAP_SETFCAP,CAP_SETGID,CAP_SETPCAP,CAP_SETUID,CAP_SYS_CHROOT rootless: false seccompEnabled: true seccompProfilePath: /usr/share/containers/seccomp.json selinuxEnabled: false serviceIsRemote: true slirp4netns: executable: "" package: "" version: "" swapFree: 0 swapTotal: 0 uptime: 28m 37s registries: docker.io: Blocked: false Insecure: false Location: mirror.gcr.io MirrorByDigestOnly: false Mirrors: null Prefix: docker.io docker.io/library: Blocked: false Insecure: false Location: quay.io/libpod MirrorByDigestOnly: false Mirrors: null Prefix: docker.io/library search: - docker.io - quay.io - registry.fedoraproject.org store: configFile: /etc/containers/storage.conf containerStore: number: 0 paused: 0 running: 0 stopped: 0 graphDriverName: vfs graphOptions: vfs.imagestore: /tmp/podman/imagecachedir graphRoot: /tmp/podman_test627720548/crio graphStatus: {} imageStore: number: 12 runRoot: /tmp/podman_test627720548/crio-run volumePath: /tmp/podman_test627720548/crio/volumes version: APIVersion: 4.0.0-dev Built: 1628078517 BuiltTime: Wed Aug 4 12:01:57 2021 GitCommit: 2da8cc7c6ecf70f2c55311aeba2693ca9b67af4e GoVersion: go1.15.11 OsArch: linux/amd64 Version: 4.0.0-dev
[+1614s] "unlinkat /tmp/podman/imagecachedir: directory not empty"

@rhatdan
Handle timezone on server containers.conf
f40a0e7 
Fixes: containers#11124

Signed-off-by: Daniel J Walsh <[email protected]>
Signed-off-by: Daniel J Walsh <[email protected]>
Signed-off-by: Daniel J Walsh <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 4, 2021

New changes are detected. LGTM label has been removed.

@rhatdan rhatdan added the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2021
@rhatdan
Copy link
Member Author

rhatdan commented Aug 4, 2021

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 4, 2021
@openshift-ci openshift-ci bot merged commit c887018 into containers:main Aug 4, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Luap99 Luap99 Luap99 left review comments

@vrothberg vrothberg vrothberg left review comments

@saschagrunert saschagrunert saschagrunert approved these changes

Assignees

@Luap99 Luap99

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

If container started via REST API timezone setting from containers.conf is not considered
4 participants
@rhatdan @saschagrunert @vrothberg @Luap99