Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3.3] Disable aarch64 support #11120

Merged
merged 1 commit into from
Aug 4, 2021
Merged

Conversation

baude
Copy link
Member

@baude baude commented Aug 3, 2021

until we have a fedora coreos images officially on aarch64, we cannot run podman machine on aarch64 linux. Moreover, on Apple Silicon, we need upstream patches for qemu to be merged and release.

[NO TESTS NEEDED]

Signed-off-by: Brent Baude [email protected]

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 3, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2021
until we have a fedora coreos images officially on aarch64, we cannot run podman machine on aarch64 linux.  Moreover, on Apple Silicon, we need upstream patches for qemu to be merged and release.

[NO TESTS NEEDED]

Signed-off-by: Brent Baude <[email protected]>
@baude baude force-pushed the 3.3disablearm64 branch from 9f8759c to b1c9c5b Compare August 3, 2021 18:41
@jwhonce
Copy link
Member

jwhonce commented Aug 3, 2021

LGTM

@vrothberg vrothberg changed the title Disable aarch64 support [v3.3] Disable aarch64 support Aug 4, 2021
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very elegant doing that via cobra 👍

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2021
@openshift-ci openshift-ci bot merged commit 57422d2 into containers:v3.3 Aug 4, 2021
@rhatdan
Copy link
Member

rhatdan commented Aug 4, 2021

I thought you were going to define a hidden environment variable to allow you to play with this?

@baude baude deleted the 3.3disablearm64 branch May 18, 2022 15:18
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants