Do not add an entry to /etc/hosts with --net=host
#11118
Merged
+18
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
mheon
force-pushed
the
use_host_resolveconf
branch
from
1676a45 to
952c857
Compare
|
code LGTM but tests failing |
Luap99
reviewed
Aug 4, 2021
To match Docker's behavior, in the `--net=host` case, we need to use the host's `/etc/hosts` file, unmodified (without adding an entry for the container). We will still respect hosts from `--add-host` but will not make any automatic changes. Fortuntely, this is strictly a matter of removal and refactoring as we already base our `/etc/hosts` on the host's version - just need to remove the code that added entries when net=host was set. Fixes containers#10319 Signed-off-by: Matthew Heon <[email protected]>
mheon
force-pushed
the
use_host_resolveconf
branch
from
952c857 to
cfcd1e1
Compare
|
Well, that test will never work now. Removing it. |
|
/lgtm |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
Can someone please confirm, if this fix available in 2.2.1 release as well or merged into latest only? |
|
No, it is not available in v2.2.1. That release is long since out of support, and is no longer receiving backports. |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To match Docker's behavior, in the
--net=hostcase, we need to use the host's/etc/hostsfile, unmodified (without adding an entry for the container). We will still respect hosts from--add-hostbut will not make any automatic changes.Fortuntely, this is strictly a matter of removal and refactoring as we already base our
/etc/hostson the host's version - just need to remove the code that added entries when net=host was set.Fixes #10319