InfraContainer Rework #11102
Merged
InfraContainer Rework #11102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
cdoern
force-pushed
the
infraEnhance
branch
14 times, most recently
from
8ebed50 to
6c7785a
Compare
openshift-ci
bot
added
the
needs-rebase
openshift-ci
bot
removed
the
needs-rebase
cdoern
force-pushed
the
infraEnhance
branch
2 times, most recently
from
db266ff to
e0c4b08
Compare
openshift-ci
bot
added
the
needs-rebase
cdoern
force-pushed
the
infraEnhance
branch
2 times, most recently
from
907e931 to
e867f7a
Compare
openshift-ci
bot
removed
the
needs-rebase
cdoern
force-pushed
the
infraEnhance
branch
6 times, most recently
from
cdd3184 to
bb8010a
Compare
cdoern
force-pushed
the
infraEnhance
branch
14 times, most recently
from
a68fa20 to
ca80399
Compare
Luap99
reviewed
Aug 26, 2021
|
@mheon PTAL, all tests passing and I think I avoided any breaking changes in the libpod API. sorry for all of the pings on this but thank you for your help! |
|
LGTM. My concern is addressed but @mheon should do a final review. |
mheon
reviewed
Aug 26, 2021
cdoern
force-pushed
the
infraEnhance
branch
2 times, most recently
from
d30d3e9 to
1636a37
Compare
InfraContainer should go through the same creation process as regular containers. This change was from the cmd level down, involving new container CLI opts and specgen creating functions. What now happens is that both container and pod cli options are populated in cmd and used to create a podSpecgen and a containerSpecgen. The process then goes as follows FillOutSpecGen (infra) -> MapSpec (podOpts -> infraOpts) -> PodCreate -> MakePod -> createPodOptions -> NewPod -> CompleteSpec (infra) -> MakeContainer -> NewContainer -> newContainer -> AddInfra (to pod state) Signed-off-by: cdoern <[email protected]>
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InfraContainer should go through the same creation process as regular containers. This change was from the cmd level
down, involving new container CLI opts and specgen creating functions. What now happens is that both container and pod
cli options are populated in cmd and used to create a podSpecgen and a containerSpecgen. The process then goes as follows
FillOutSpecGen (infra) -> PodCreate -> MakePod -> MapSpec (podSpec -> infraSpec) -> createPodOptions -> NewPod -> CompleteSpec (infra) -> MakeContainer -> ExecuteCreate -> NewContainer -> newContainer -> AddInfra (to pod state)
removed runtime_pod_infra_linux.go, infra now is on its way to following basic container creation path.
resolves #10933
Signed-off-by: cdoern [email protected]