exec: fix cleanup #11055
exec: fix cleanup #11055
Conversation
Commit 341e6a1 made sure that all exec sessions are getting cleaned up. But it also came with a peformance penalty. Fix that penalty by spawning the cleanup process to really only cleanup the exec session without attempting to remove the container. [NO TESTS NEEDED] since we have no means to test such performance issues in CI. Fixes: containers#10701 Signed-off-by: Valentin Rothberg <[email protected]>
openshift-ci
bot
added
the
approved
|
This completely fixes the |
|
Excellent, thank you for checking and for reporting the issue! @containers/podman-maintainers PTAL |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Merge me please |
|
/lgtm |
|
Do we know if this made it into any release, or was it purely in upstream? |
|
|
|
Yes, it only hit the main branch. With 3.3 around the corner, I didn't bother doing a BZ dance. |
github-actions
bot
added
the
locked - please file new issue/PR
Commit 341e6a1 made sure that all exec sessions are getting cleaned up.
But it also came with a peformance penalty. Fix that penalty by
spawning the cleanup process to really only cleanup the exec session
without attempting to remove the container.
[NO TESTS NEEDED] since we have no means to test such performance
issues in CI.
Fixes: #10701
Signed-off-by: Valentin Rothberg [email protected]
@edsantiago PTAL