-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI:DOCS] Add notes to flags not supported on cgroups V2 #11013
Conversation
@@ -181,6 +181,8 @@ Limit the CPU real-time period in microseconds | |||
|
|||
Limit the container's Real Time CPU usage. This flag tell the kernel to restrict the container's Real Time CPU usage to the period you specify. | |||
|
|||
This flag is not supported on cgroups V2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add "systems" to the end - so "not supported on cgroups v2 systems."
@TomSweeneyRedHat PTAL |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hshiina, mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Clarify what flags are not supported on cgroups V2 in documentation. Signed-off-by: Hironori Shiina <[email protected]>
LGTM |
BTW Do we give a decent error when a user attempts one of these flags? Something like this option is not supported on cgroup v2 systems, as opposed to some random file object does not exist in the cgroup file system? |
Podman itself won't give any error - we rely on the OCI runtime. Which probably means it's the latter. |
Well Podman could check if it is running in cgroupv2 and then report errors on the unsupported options. Although this would not work as easily on the --remote. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Clarify what flags are not supported on cgroups V2 in documentation.
The following flags of
create
andrun
commands are not supported:Signed-off-by: Hironori Shiina [email protected]