Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:DOCS] Add notes to flags not supported on cgroups V2 #11013

Merged
merged 1 commit into from
Jul 22, 2021

Conversation

hshiina
Copy link
Contributor

@hshiina hshiina commented Jul 21, 2021

Clarify what flags are not supported on cgroups V2 in documentation.
The following flags of create and run commands are not supported:

  • --cpu-rt-period
  • --cpu-rt-runtime
  • --kernel-memory
  • --memory-swappiness

Signed-off-by: Hironori Shiina [email protected]

@@ -181,6 +181,8 @@ Limit the CPU real-time period in microseconds

Limit the container's Real Time CPU usage. This flag tell the kernel to restrict the container's Real Time CPU usage to the period you specify.

This flag is not supported on cgroups V2.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add "systems" to the end - so "not supported on cgroups v2 systems."

@mheon
Copy link
Member

mheon commented Jul 21, 2021

@TomSweeneyRedHat PTAL

@mheon
Copy link
Member

mheon commented Jul 21, 2021

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hshiina, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2021
Clarify what flags are not supported on cgroups V2 in documentation.

Signed-off-by: Hironori Shiina <[email protected]>
@rhatdan
Copy link
Member

rhatdan commented Jul 22, 2021

LGTM
Would love a head nod from @giuseppe to confirm the lack of support of these options.

@rhatdan
Copy link
Member

rhatdan commented Jul 22, 2021

BTW Do we give a decent error when a user attempts one of these flags? Something like this option is not supported on cgroup v2 systems, as opposed to some random file object does not exist in the cgroup file system?

@mheon
Copy link
Member

mheon commented Jul 22, 2021

Podman itself won't give any error - we rely on the OCI runtime. Which probably means it's the latter.

@rhatdan
Copy link
Member

rhatdan commented Jul 22, 2021

Well Podman could check if it is running in cgroupv2 and then report errors on the unsupported options. Although this would not work as easily on the --remote.

Copy link
Member

@ashley-cui ashley-cui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2021
@openshift-merge-robot openshift-merge-robot merged commit e6fb92f into containers:main Jul 22, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants