Return macvlan object in /network REST API response

[vikas-goel]

Fixes: #10266

Signed-off-by: Vikas Goel [email protected]

[vikas-goel]

@Luap99 ,
Please review this PR

[vikas-goel]

/auto-cc

[rhatdan]

/approve
@mheon PTAL

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan, vikas-goel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mheon]

LGTM but I think we need a review from @baude before merge

[vikas-goel]

/assign @Luap99

[Luap99]

Code LGTM but the test not, you are testing the libpod endpoint and your code fixes a bug in the docker compat api. The test should call the compat api.

[vikas-goel]

Code LGTM but the test not, you are testing the libpod endpoint and your code fixes a bug in the docker compat api. The test should call the compat api.

Sure, @Luap99. Will the following be sufficient?

t GET networks/macvlan1 200
length=1

[Luap99]

t GET networks/macvlan1 200
length=1

yes but you should check the name at least not only length

[vikas-goel]

t GET networks/macvlan1 200
length=1

yes but you should check the name at least not only length

Ok. I will add to it.
.Name=macvlan1

[baude]

/check-dco

[vikas-goel]

The test for this PR change is passing.

[+0067s] ok 664 [35-networks] GET libpod/networks/macvlan1/json : status=200
[+0067s] ok 665 [35-networks] GET libpod/networks/macvlan1/json : .name=macvlan1
[+0067s] ok 666 [35-networks] GET networks/macvlan1 : status=200
[+0067s] ok 667 [35-networks] GET networks/macvlan1 : .Name=macvlan1
[+0067s] ok 668 [35-networks] DELETE libpod/networks/macvlan1 : status=200
[+0067s] ok 669 [35-networks] DELETE libpod/networks/macvlan1 : .[0].Name ('macvlan1') ~ macvlan1
[+0067s] ok 670 [35-networks] DELETE libpod/networks/macvlan1 : .[0].Err=null

The two test suites APIv2 test on fedora-34 and compose test on fedora-34 (root) failing for unrelated reasons. How can we overcome the failures?

[Luap99]

I restarted the failing tests.

[TomSweeneyRedHat]

@vikas-goel thanks for the work on this. @edsantiago is the below a known flake we're chasing?

[+0217s] Traceback (most recent call last):
[+0217s]   File "/var/tmp/go/src/github.com/containers/podman/test/python/docker/compat/test_containers.py", line 253, in test_mount_preexisting_dir
[+0217s]     self.assertTrue(out.startswith(b'1042:1043'), "assert correct uid/gid")
[+0217s] AssertionError: False is not true : assert correct uid/gid

[edsantiago]

@TomSweeneyRedHat yes, "false is not true" is one of the flakes I've been seeing a lot of. I haven't filed an issue for it because the error message is so annoying. I've restarted the test.

[vikas-goel]

@Luap99 ,
The PR has all the suggestions incorporated, the approval and the checks passing.

[Luap99]

/lgtm

[Luap99]

Thanks @vikas-goel

[mheon]

@Luap99 @baude PTAL and merge

[Luap99]

@Luap99 @baude PTAL and merge

@mheon I already merged this one!

[mheon]

What I get for commenting without refreshing the page. Thanks!

[vikas-goel]

Thank you all.