-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI:DOCS] Fix up documentation of the userns audit flag #10909
Conversation
2695ebb
to
ce423c5
Compare
- **auto[:**_OPTIONS,..._**]**: automatically create a namespace. It is possible to specify these options to `auto`: | ||
**auto[:_OPTIONS,..._]**: automatically create a unigue user namespace. | ||
|
||
The `--userns=auto` flag, requires that the user name `containers` and a range of subordinate user ids that the Podman container is allowed to use be specified in the /etc/subuid and /etc/subgid files. Example: `containers:2147483647:2147483648`. Podman allocates unigue ranges of UIDs and GIDs from the `containers` group. The size of the ranges is based on the number of UIDs required in the image. The number of UIDs and GIDs can be overridden with the `size` option. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we mention root vs rootless usage here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a comment about only being rootless.
docs/source/markdown/podman-run.1.md
Outdated
@@ -1676,6 +1686,16 @@ $ echo "asdf" | podman run --rm -i --entrypoint /bin/cat someimage | |||
asdf | |||
``` | |||
|
|||
### Setting automatic User Namespace separated containers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this just in run, not create?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it will work with create as well. But I wanted to show examples and the userns generated, with the main goal showing they are unigue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a create example.
@containers/podman-maintainers PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The `--userns=auto` flag, requires that the user name `containers` and a range of subordinate user ids that the Podman container is allowed to use be specified in the /etc/subuid and /etc/subgid files. Example: `containers:2147483647:2147483648`. Podman allocates unigue ranges of UIDs and GIDs from the `containers` group. The size of the ranges is based on the number of UIDs required in the image. The number of UIDs and GIDs can be overridden with the `size` option. The `auto` options currently does not work in rootless mode | ||
|
||
Valid `auto`options: | ||
|
||
- **gidmapping=**_HOST_GID:CONTAINER_GID:SIZE_: to force a GID mapping to be present in the user namespace. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to fit the new manpage syntax, these should be only a single asterisk, except for the default value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple nits that need tending....
1877a7c
to
883495f
Compare
Add reference to the `containers` user in the /etc/subuid and /etc/subgid files. Fixes: containers#10906 Signed-off-by: Daniel J Walsh <[email protected]>
LGTM |
/lgtm |
/hold cancel |
Add reference to the
containers
user in the /etc/subuid and/etc/subgid files.
Fixes: #10906
Signed-off-by: Daniel J Walsh [email protected]