Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: uid/gid for volume mounted to existing dir #10905

Merged
merged 1 commit into from
Jul 12, 2021

Conversation

matejvasek
Copy link
Contributor

If mounting to existing directory the uid/gid should be preserved.
Primary uid/gid of container shouldn't be used.

resolves #10776

If mounting to existing directory the uid/gid should be preserved.
Primary uid/gid of container shouldn't be used.

Signed-off-by: Matej Vasek <[email protected]>
@matejvasek
Copy link
Contributor Author

/cc @rhatdan

@openshift-ci openshift-ci bot requested a review from rhatdan July 12, 2021 13:00
@rhatdan
Copy link
Member

rhatdan commented Jul 12, 2021

LGTM
/approve
@mheon PTAL

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 12, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2021
@mheon
Copy link
Member

mheon commented Jul 12, 2021

/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 12, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2021
@rhatdan
Copy link
Member

rhatdan commented Jul 12, 2021

/hold cancel

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Volume mounting changes owner of existing directory
4 participants