manifest create subcommand should accept more than 2 arguments

[rsevilla87]

The current implementation does not allow passing more than one image.

• Before

$ podman manifest create quay.io/rsevilla/perfapp:manifest-latest2 quay.io/rsevilla/perfapp:latest quay.io/rsevilla/perfapp:arm
Error: accepts between 1 and 2 arg(s), received 3  

• After:

$ ./bin/podman manifest create quay.io/rsevilla/perfapp:manifest-latest2 quay.io/rsevilla/perfapp:latest quay.io/rsevilla/perfapp:arm
9c55826980e16d0202147e5ea01a191fa95d58a3614173e8a4e3e38cc384a7ae
$ podman manifest inspect quay.io/rsevilla/perfapp:manifest-latest2
{
    "schemaVersion": 2,
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "manifests": [
        {
            "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
            "size": 591,
            "digest": "sha256:9d1a6c94edea56d47a8f08dbe957eae6ae6797847017e6e243d06b424735ddfc",
            "platform": {
                "architecture": "amd64",
                "os": "linux"
            }
        },
        {
            "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
            "size": 591,
            "digest": "sha256:8aec9d12c9033fddcd1840c7bc17b5b5671637e68301334421ce9876a5f2a7d8",
            "platform": {
                "architecture": "arm64",
                "os": "linux"
            }
        }
    ]
}

Signed-off-by: Raul Sevilla [email protected]

[mheon]

@vrothberg PTAL

[rhatdan]

This also better matches Docker behavior.

LGTM
/approve

[rhatdan]

Testing is not happy at all, however.

[rhatdan]

I think this should be minimalargs(2)

[rsevilla87]

Hey @rhatdan, We currently support creating "empty" manifests, so I think minimalargs(1) is correct.

$ ./bin/podman manifest create mylist:v1.11
a64c46f246df4372ccbf105de02669b123d62fcc2e68dcd055ea9f56a9f05b9

[vrothberg]

I concur with @rsevilla87 👍

[vrothberg]

To make CI pass, you need to change Use: "create [options] LIST [IMAGE]", to Use: "create [options] LIST [IMAGE...]",

[rhatdan]

/approve
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan, rsevilla87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment