Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vendor of containers/common and containers/buildah #10899

Closed
wants to merge 1 commit into from

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Jul 11, 2021

[NO TESTS NEEDED] Since this is just code changes to make vendor work

Existing tests should find issues.

Signed-off-by: Daniel J Walsh [email protected]

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 11, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2021
[NO TESTS NEEDED] Since this is just code changes to make vendor work

Existing tests should find issues.

Signed-off-by: Daniel J Walsh <[email protected]>
@rhatdan
Copy link
Member Author

rhatdan commented Jul 13, 2021

@edsantiago Buildah bud issues.

@edsantiago
Copy link
Member

The --runtime failure (old runc version) is being tracked in #10848

The bud-http-Dockerfile error, I have no idea; I would assume it's a flake, but there's no point in rerunning because the --runtime error is a hard-and-fast fatal error, not fixable without @cevich's help.

@vrothberg
Copy link
Member

I am closing this in favor of #10848

@vrothberg vrothberg closed this Jul 15, 2021
@vrothberg
Copy link
Member

Reopening since I didn't notice the log changes. I'd still prefer #10848 to get in before as as it outlines the changes in libimage.

@vrothberg vrothberg reopened this Jul 15, 2021
@cevich
Copy link
Member

cevich commented Jul 15, 2021

I'm assuming "my help" means new images 😀

I have been working on this for more than a week, but there are a combination of SNAFU's in the way. We're creeping forward on them, but it's all package update dependent. So, it's kind of "Hurry up and wait" at the moment. In any case, keep an eye on #10829 where it should eventually all come together.

If it's something else I can help with, of course just let me know.

@rhatdan
Copy link
Member Author

rhatdan commented Jul 15, 2021

We could always drop support for f33 for a few weeks while we wait for this to be fixed.

@cevich
Copy link
Member

cevich commented Jul 16, 2021

a few weeks while we wait for this to be fixed.

TBH, my biggest fear in that is forgetting to turn it back on (maybe on purpose) 😆

Seriously though, I'd prefer to side-load in some not-yet-in-testing fixes than turn it off entirely. Otherwise during the time F33 testing is paused, I worry some new flakes/breaks will creep in unnoticed.

@rhatdan rhatdan closed this Jul 16, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants