-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update vendor of containers/common and containers/buildah #10899
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[NO TESTS NEEDED] Since this is just code changes to make vendor work Existing tests should find issues. Signed-off-by: Daniel J Walsh <[email protected]>
@edsantiago Buildah bud issues. |
I am closing this in favor of #10848 |
Reopening since I didn't notice the log changes. I'd still prefer #10848 to get in before as as it outlines the changes in libimage. |
I'm assuming "my help" means new images 😀 I have been working on this for more than a week, but there are a combination of SNAFU's in the way. We're creeping forward on them, but it's all package update dependent. So, it's kind of "Hurry up and wait" at the moment. In any case, keep an eye on #10829 where it should eventually all come together. If it's something else I can help with, of course just let me know. |
We could always drop support for f33 for a few weeks while we wait for this to be fixed. |
TBH, my biggest fear in that is forgetting to turn it back on (maybe on purpose) 😆 Seriously though, I'd prefer to side-load in some not-yet-in-testing fixes than turn it off entirely. Otherwise during the time F33 testing is paused, I worry some new flakes/breaks will creep in unnoticed. |
[NO TESTS NEEDED] Since this is just code changes to make vendor work
Existing tests should find issues.
Signed-off-by: Daniel J Walsh [email protected]