Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cp: do not allow dir->file copying #10772

Merged
merged 1 commit into from
Jun 24, 2021
Merged

cp: do not allow dir->file copying #10772

merged 1 commit into from
Jun 24, 2021

Conversation

vrothberg
Copy link
Member

Fix a bug in podman-cp to forbid copying directories to files.
Previously, the directory was copied to the parent directory of the file
which is wrong.

Signed-off-by: Valentin Rothberg [email protected]

@vrothberg
cp: do not allow dir->file copying
b108269 
Fix a bug in `podman-cp` to forbid copying directories to files.
Previously, the directory was copied to the parent directory of the file
which is wrong.

Signed-off-by: Valentin Rothberg <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 24, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2021
@vrothberg vrothberg added the needs-backport Indicates if changes in a PR should be backported to some releases. label Jun 24, 2021
@vrothberg vrothberg mentioned this pull request Jun 24, 2021
Closed
@vrothberg
Copy link
Member Author

A late one for 3.2.

@containers/podman-maintainers PTAL

@vrothberg vrothberg mentioned this pull request Jun 24, 2021
Merged
Luap99
Luap99 reviewed Jun 24, 2021
View reviewed changes
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan
Copy link
Member

rhatdan commented Jun 24, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2021
@openshift-merge-robot openshift-merge-robot merged commit f29f6aa into containers:master Jun 24, 2021
@vrothberg vrothberg deleted the fix-cp branch June 24, 2021 13:52
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Luap99 Luap99 Luap99 left review comments

Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. needs-backport Indicates if changes in a PR should be backported to some releases.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vrothberg @rhatdan @Luap99 @openshift-merge-robot