-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable tty-size exec checks in system tests #10758
Conversation
As discussed in containers#10710, the additional checks for podman-exec added by commit 666f555 are extremely flaky and appear in nearly every PR I have see this week. Let's temporarily disable the checks and reenable them on containers#10710 is fixed. Signed-off-by: Valentin Rothberg <[email protected]>
LGTM |
@containers/podman-maintainers PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Merge me |
/lgtm |
As discussed in #10710, the additional checks for podman-exec added by
commit 666f555 are extremely flaky and appear in nearly every PR
I have see this week.
Let's temporarily disable the checks and reenable them once #10710 is
fixed.
Signed-off-by: Valentin Rothberg [email protected]