getContainerNetworkInfo: lock netNsCtr before sync

[Luap99]

syncContainer() requires the container to be locked, otherwise we can
end up with undefined behavior.

[NO TESTS NEEDED]

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Luap99]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vrothberg]

Other than the nit, LGTM

Thanks!

[Luap99]

It does not fix #10090 according to @thmo on IRC

[mheon]

LGTM, even if this isn't a fix for the issue - this could cause no end of trouble elsewhere at some point.

[mheon]

/lgtm
/hold

[TomSweeneyRedHat]

Changes LGTM, but one of the TTY tests is failing. I can't imagine it's due to this change, but it doesn't look flakey either....

[vrothberg]

Changes LGTM, but one of the TTY tests is failing. I can't imagine it's due to this change, but it doesn't look flakey either....

It's a very frequent flake in CI at the moment ( see #10710).

[Luap99]

/hold cancel