Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cirrus: Update Ubuntu VM images #10709

Closed
wants to merge 3 commits into from
Closed

Cirrus: Update Ubuntu VM images #10709

wants to merge 3 commits into from

Conversation

cevich
Copy link
Member

@cevich cevich commented Jun 17, 2021 •
edited
Loading

These images include a fix for:
containers/common#631

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 17, 2021
@cevich cevich mentioned this pull request Jun 17, 2021
Merged
@cevich cevich force-pushed the update_images_again branch from 5be6b91 to 9efcf62 Compare June 17, 2021 15:16
@cevich
Copy link
Member Author

cevich commented Jun 17, 2021

/hold forever

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 17, 2021
@cevich
Copy link
Member Author

cevich commented Jun 17, 2021

bdflush syscall permission denied problem from buildah PR is reproducing here also. using freshly built image c4805484248039424.

Trying the image I built 3-days earlier: c4635821094469632

@cevich cevich changed the title Cirrus: Update Ubuntu VM images again DO NOT MERGE: Testing runc bdflush problem Jun 17, 2021
@cevich
Copy link
Member Author

cevich commented Jun 17, 2021

c4635821094469632 does not reproduce the problem

@cevich cevich mentioned this pull request Jun 17, 2021
Closed
@cevich cevich force-pushed the update_images_again branch from f4c50f6 to d1a611c Compare June 23, 2021 13:58
@cevich
Copy link
Member Author

cevich commented Jun 23, 2021

Hrmmmm, it passed, that was unexpected.

@cevich cevich force-pushed the update_images_again branch from d1a611c to f95e4d7 Compare June 25, 2021 19:52
@cevich cevich changed the title DO NOT MERGE: Testing runc bdflush problem Cirrus: Update Ubuntu VM images Jun 28, 2021
@cevich cevich force-pushed the update_images_again branch from ceedca9 to 35cb78b Compare June 28, 2021 20:49
@cevich cevich marked this pull request as ready for review June 28, 2021 20:49
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 28, 2021
@cevich
Copy link
Member Author

cevich commented Jun 29, 2021

Ugh, this is really strange. Fedora 33/34 think the /dev/kvm device doesn't exist and the Ubuntus throw an error inside the container.

@cevich
Copy link
Member Author

cevich commented Jun 29, 2021

Okay right...the Fedora problem is explainable - we're using really old images due to need of an SELinux-related updated (IIRC, already working it's way through the system). Ignoring this for now.

The Ubuntu failures are a true anomaly though. I did go into a VM and verify the device (on the host) does exist. @mheon these VM's have just had nested-virt enabled on them (previously it was disabled). I'm guessing this is why the Ubuntu test failures got missed: The device node wasn't there, now it is (test skips if file is missing). Is this even a valid test to run in rootless mode? Maybe should I switch the test to use a less-special device, like /dev/random or something?

@cevich cevich force-pushed the update_images_again branch from 35cb78b to 5cc1f86 Compare June 30, 2021 15:46
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 30, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cevich
To complete the pull request process, please assign umohnani8 after the PR has been reviewed.
You can assign the PR to them by writing /assign @umohnani8 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member

rhatdan commented Jun 30, 2021

I think the SELinux issues should be fixed in Fedora now.

@cevich
Copy link
Member Author

cevich commented Jun 30, 2021

I think the SELinux issues should be fixed in Fedora now.

Oh great, thanks for reminding me. I'll revert that change.

cevich added 3 commits June 30, 2021 13:31
@cevich
Cirrus: Update Ubuntu VM images
0d38046 
These images include a fix for:
containers/common#631

Signed-off-by: Chris Evich <[email protected]>
@cevich
Revert ".cirrus.yml: use c5521575421149184 for Ubuntu"
a46dbce 
This reverts commit 404d5ed.

Also minor update to an unrelated FIXME comment.

Signed-off-by: Chris Evich <[email protected]>
@cevich
Workaround host availability of /dev/kvm
ddfdd16 
This test has been failing for a long time but nobody noticed because CI
doesn't have the device node (nested-VM support was disabled).  After
having enabled nested VM support, tests fail due to some unknown
special-handling of this device.

Fix both problems by removing the `skip()` and switching to a more generic
device which is only present when `--privileged` is used.

Signed-off-by: Chris Evich <[email protected]>
@cevich cevich force-pushed the update_images_again branch from 5cc1f86 to ddfdd16 Compare June 30, 2021 17:32
@cevich cevich closed this Jun 30, 2021
@cevich cevich deleted the update_images_again branch June 30, 2021 17:59
@cevich cevich restored the update_images_again branch June 30, 2021 18:00
@cevich
Copy link
Member Author

cevich commented Jun 30, 2021

Oof, what did I do 😕

@cevich cevich deleted the update_images_again branch June 30, 2021 19:21
@cevich
Copy link
Member Author

cevich commented Jun 30, 2021

Re-opened as #10829

@cevich cevich mentioned this pull request Jul 1, 2021
Merged
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cevich @rhatdan