Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix resize race with podman exec -it #10683

Merged
merged 1 commit into from
Jun 16, 2021
Merged

Fix resize race with podman exec -it #10683

merged 1 commit into from
Jun 16, 2021

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Jun 15, 2021

When starting a process with podman exec -it the terminal is resized
after the process is started. To fix this allow exec start to accept the
terminal height and width as parameter and let it resize right before
the process is started.

Fixes #10560

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 15, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 15, 2021
@Luap99 Luap99 force-pushed the exec-resize branch 3 times, most recently from 13cfb1a to 18f0d40 Compare June 15, 2021 12:24
mheon
mheon reviewed Jun 16, 2021
View reviewed changes
pkg/api/server/register_exec.go Outdated
@@ -272,7 +272,13 @@ func (s *APIServer) registerExecHandlers(r *mux.Router) error {
// description: Detach from the command. Not presently supported.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely supported, I don't know why the docs say it isn't.

@mheon
Copy link
Member

mheon commented Jun 16, 2021

Approach LGTM, but the function signatures modified should also have their comments changed to describe the new parameter.

@Luap99
Fix resize race with podman exec -it
666f555 
When starting a process with `podman exec -it` the terminal is resized
after the process is started. To fix this allow exec start to accept the
terminal height and width as parameter and let it resize right before
the process is started.

Fixes containers#10560

Signed-off-by: Paul Holzinger <[email protected]>
@rhatdan
Copy link
Member

rhatdan commented Jun 16, 2021

LGTM

@rhatdan
Copy link
Member

rhatdan commented Jun 16, 2021

/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 16, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2021
@rhatdan
Copy link
Member

rhatdan commented Jun 16, 2021

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 16, 2021
@openshift-merge-robot openshift-merge-robot merged commit 2509a81 into containers:master Jun 16, 2021
@edsantiago
Copy link
Member

Uh-oh. My flake catcher detected that the new test flaked (sys podman ubuntu-2104 root host):

# # podman exec -it mystty stty size
# stty: standard input

# #/vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv
# #|     FAIL: stty under podman exec reads the correct dimensions
# #| expected: '41 62'
# #|   actual: 'stty: standard input
'
# #\^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

This is really really bad: it means that the test is not reliable, and is going to start flaking in CI.

@edsantiago edsantiago mentioned this pull request Jun 17, 2021
Open
@Luap99 Luap99 deleted the exec-resize branch April 29, 2022 14:21
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mheon mheon mheon left review comments

Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

podman exec --tty resizes only after the process is started
5 participants
@Luap99 @mheon @rhatdan @edsantiago @openshift-merge-robot