-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix building static podman-remote #10679
Fix building static podman-remote #10679
Conversation
As near as I can tell, sometime between `v1.6.4` and `v1.9` the definition of `LDFLAGS_PODMAN_STATIC` was both created and lost. Additionally, after a refactoring of the `Makefile` it was possible to enable CGO (which will cause a dynamic binary to be built). Fix both issues by adding the missing definition and forcing CGO to be disabled. Signed-off-by: Chris Evich <[email protected]>
Alert/Danger/Warning/Caution: I don't know what I'm doing...just following some random blog post google dug up for me. A local test showed It's also (obviously) not going to replace the |
I don't think we can fix the 3.2.x already-built binaries easily. We can do subsequent releases, but backporting to existing tags seems like a bad idea. |
Okay. Hmmm, we do have that nix-based alt-build. Maybe it produced a viable 3.2.0 static binary at the time... |
...We have a winner! The static nix build for v3.2.0 was successful (Download), all it needs is sticking into a tarball 😃 |
(clicked the re-run buttons) |
(clicked the re-run buttons again...and again) |
LGTM |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cevich, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Fixes #10656
As near as I can tell, sometime between
v1.6.4
andv1.9
the definitionof
LDFLAGS_PODMAN_STATIC
was both created and lost. Additionally, aftera refactoring of the
Makefile
it was possible to enable CGO (whichwill cause a dynamic binary to be built). Fix both issues by adding the
missing definition and forcing CGO to be disabled.