Fix build tags for pkg/machine... #10634
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Podman machine is only intended for amd64 and arm64 architectures, set the correct buildtags so that the `pkg/machine`, `pkg/machine/qemu` and `pkg/machine/libvirt` packages compile correctly. [NO TESTS NEEDED] Fixes containers#10625 Signed-off-by: Paul Holzinger <[email protected]>
There was a problem hiding this comment.
I think commas are ANDs and spaces are OR's? So I think the build tags should be separated by spaces rather than commas, if I'm reading this correctly: https://golang.org/cmd/go/#hdr-Build_constraints
|
No the build tags should be correct, they are the same as in /cmd/podman/machine. |
|
/lgtm |
|
@Luap99, can you create a backport for the v3.2 branch? |
|
@mheon Should I open a PR to backport or do you include this in your final release PR? |
|
Oh duh, I read the build tags wrong, haven't had coffee this morning yet,my bad |
|
@Luap99 I'll grab it - thanks for getting this one handled quickly. |
github-actions
bot
added
the
locked - please file new issue/PR
Podman machine is only intended for amd64 and arm64 architectures, set
the correct buildtags so that the
pkg/machine,pkg/machine/qemuandpkg/machine/libvirtpackages compile correctly.Fixes #10625