[CI:DOCS] podman-run.1.md:detach-keys: spell the default value just once #10629
Conversation
|
Where is it specified elsewhere? BTW You have to sign your commits. git commit -a --amend -s |
|
The short description of --detach-keys spells the default value twice. The second mention is three lines after the first one. |
|
Ok, But I find it harder to find now. I think we should reorganize the --detach-keys definition up a few lines, to include the defaults under the option. But this is not a hard call on my part. @TomSweeneyRedHat WDYT? |
docs/source/markdown/podman-run.1.md
Outdated
| @@ -281,7 +281,7 @@ it in the **containers.conf** file: see **containers.conf(5)** for more informat | |||
|
|
|||
| #### **--detach-keys**=*sequence* | |||
|
|
|||
| Specify the key sequence for detaching a container. Format is a single character `[a-Z]` or one or more `ctrl-<value>` characters where `<value>` is one of: `a-z`, `@`, `^`, `[`, `,` or `_`. Specifying "" will disable this feature. The default is *ctrl-p,ctrl-q*. | |||
| Specify the key sequence for detaching a container. Format is a single character `[a-Z]` or one or more `ctrl-<value>` characters where `<value>` is one of: `a-z`, `@`, `^`, `[`, `,` or `_`. Specifying "" will disable this feature. | |||
There was a problem hiding this comment.
| Specify the key sequence for detaching a container. Format is a single character `[a-Z]` or one or more `ctrl-<value>` characters where `<value>` is one of: `a-z`, `@`, `^`, `[`, `,` or `_`. Specifying "" will disable this feature. | |
| Specify the key sequence for detaching a container. Format is a single character `[a-Z]` or one or more `ctrl-<value>` characters where `<value>` is one of: `a-z`, `@`, `^`, `[`, `,` or `_`. Specifying "" will set the sequence to the default value of *ctrl-p,ctrl-q* |
There was a problem hiding this comment.
The proposed wording Specifying "" will set the sequence to the default value of *ctrl-p,ctrl-q* does change the current meaning. I have updated the patch with the new meaning.
|
I see |
Insisting on “DCO” imposes formalities, that serve self-purpose. One cannot
assume that the submitter has time or will to read texts about symbolism in
software contributions. If the system wants to see the text
nrEAUIEUAIe eanuitdnuae EAIUEAUIAIE »ℓ§444.3.72b)°»°ℓ§euaieauuae
in each commit, people will write this, or any other text, that the system wants to
see. All such text, which presence is mandated by the system, has the same value.
Signed-off-by: Дилян Палаузов <[email protected]>
|
LGTM |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dilyanpalauzov, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
github-actions
bot
added
the
locked - please file new issue/PR
No description provided.