rootless: fix fast join userns path

[giuseppe]

commit ab88632 changed the path for
the pause.pid file but didn't update the same path in the C code.
This prevented Podman to take the fast path when the userns is already
created and to join it without re-execing itself.

Fix the path in the C code as well so we can join the rootless
user+mount namespace without having to re-exec Podman.

[NO TESTS NEEDED]

Signed-off-by: Giuseppe Scrivano [email protected]

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [giuseppe]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

LGTM
@mheon PTAL

[vrothberg]

LGTM, thank you!

[mheon]

/lgtm
/hold

[vrothberg]

A quick test locally with:

for i in {1..20}
do
        $PODMAN run -d alpine ls
done

Ran three times each:
Before the commit > 8 secs
After the commits <= 7 secs

By no means a meaningful benchmark but we may consider backporting that to 3.0 and 3.1 branches.

[giuseppe]

tests got stuck.

/retest

[giuseppe]

@cevich do I need to re-push?

[cevich]

tests got stuck.

They look okay to me (now). Perhaps github was showing broken re-run status but Cirrus was still executing?

[giuseppe]

I've closed the PR and opened it again :) That seemed to unblock the CI.

All green now!

@vrothberg PTAL

[giuseppe]

@vrothberg unping, sorry, I've not seen there are already two LGTM

/hold cancel

[giuseppe]

some backports:

#10630
#10631
#10632
#10633