implemented verbose and scope as possible #10603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwhonce
requested changes
Jun 8, 2021
pkg/api/handlers/compat/networks.go
Outdated
| // utils.Error(w, "Something went wrong.", http.StatusBadRequest, errors.Wrapf(err, "failed to parse parameters for %s", r.URL.String())) | ||
| // return | ||
| // } | ||
| //scope is only used to see if th euser passes any illegal value, verbose is not used but implemented |
There was a problem hiding this comment.
Suggested change
| //scope is only used to see if th euser passes any illegal value, verbose is not used but implemented | |
| // scope is only used to see if the user passes any illegal value, verbose is not used but implemented |
pkg/api/handlers/compat/networks.go
Outdated
| scope string | ||
| verbose bool | ||
| }{ | ||
| // override any golang type defaults |
There was a problem hiding this comment.
Given the code below should scope be defaulted to "local"?
There was a problem hiding this comment.
okay, if I do that should I then remove the http bad request check? or leave it even though it'll be redundant. edit: nevermind the decoder will overwrite it with the passed value.
cdoern
force-pushed
the
networksQuery
branch
2 times, most recently
from
7e291bf to
920e7ec
Compare
jwhonce
approved these changes
Jun 8, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cdoern, jwhonce The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
LGTM, now you need to make the tests happy. |
Signed-off-by: cdoern <[email protected]>
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: cdoern [email protected]
partial implementation of scope and verbose for /networks/{id} query. Not much else is possible for these two. Returns Bad Request is scope is anything other than local. The values docker uses for verbose output are not implemented in podman from what I can tell, and implementing would not save any space/time.