[CI:DOCS] converted query parameter for credentials to header parameter.

[cdoern]

Signed-off-by: cdoern [email protected]

Edited docs based on the fact that we added support for X-Registry-Auth and the libpod pull code seems to only parse the header instead of the credentials query parameter. If interested, we could add handling for a credentials query parameter as well.

[rhatdan]

@jwhonce @baude PTAL

[jwhonce]

@vrothberg Was there a use case you intended for the credentials query parameter?

[vrothberg]

@vrothberg Was there a use case you intended for the credentials query parameter?

I think that comes from a time from before we had the x-registry-... header plumbed.

[cdoern]

@vrothberg @jwhonce is this good to merge or do we not want to switch to x-reg? It seems to me like credentials just is not used otherwise so if you wanted I could implement it on our end instead of just sending it in the header.

[jwhonce]

/lgtm

[rhatdan]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cdoern, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment