Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support log_tag defaults from containers.conf #10583

Merged
merged 1 commit into from
Jun 24, 2021

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Jun 7, 2021

Fixes: #10204

Signed-off-by: Daniel J Walsh [email protected]

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 7, 2021
@rhatdan rhatdan changed the title [WIP] Support log_tag defaults from containers.conf Support log_tag defaults from containers.conf Jun 10, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 10, 2021
@rhatdan rhatdan force-pushed the log branch 6 times, most recently from 3d4ee9f to 0a415a6 Compare June 14, 2021 17:18
@TomSweeneyRedHat
Copy link
Member

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1764284, please set that to POST and assign to Jindrich once this merges.

@rhatdan
Copy link
Member Author

rhatdan commented Jun 21, 2021

@containers/podman-maintainers PTAL

Copy link
Member

@ashley-cui ashley-cui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nit, otherwise LGTM

pkg/specgen/generate/container.go Outdated Show resolved Hide resolved
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 23, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [rhatdan,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan rhatdan added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2021
@openshift-merge-robot openshift-merge-robot merged commit da33fc4 into containers:master Jun 24, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add log-opts in global settings, witht tags
5 participants