podman-remote build should handle -f option properly

[rhatdan]

podman-remote build has to handle multiple different locations
for the Containerfile. Currently this works in local mode but not
when using podman-remote.

Fixes: #9871

Signed-off-by: Daniel J Walsh [email protected]

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

@edsantiago PTAL

[edsantiago]

Almost working (in buildah-bud tests) but still some problems; I'm looking into them, will report back once I understand them.

[edsantiago]

Here's one problem: multiple -f flags, all except the first are ignored:

$ mkdir aaa
$ printf "FROM scratch\nCOPY Containerfile1 /\n" >aaa/Containerfile1
$ printf "COPY Containerfile2 /\n" >aaa/Containerfile2
$ bin/podman-remote build -t foo -f aaa/Containerfile1 -f aaa/Containerfile2 aaa
STEP 1: FROM scratch
STEP 2: COPY Containerfile1 /
  !!! missing STEP 3: COPY Containerfile2 /      (works fine with bin/podman)
STEP 3: COMMIT foo
--> 7a15f1ab70b
Successfully tagged localhost/foo:latest
7a15f1ab70b3e68b8f6f25fa86a1f268636d25befe1ea026849aca613d19d4b5

This may be related to (and fixable in) your PR, or it might need a separate issue. Please LMK if I should file one.

[edsantiago]

Here's another one: -f - (minus) is not handled:

$ mkdir aaa
$ echo "FROM scratch" | bin/podman-remote build -t foo -f - aaa
Error: error building: no stages to build

(works fine with non-remote podman).

[edsantiago]

The other two problems are not related to this PR. One is the --device option, which probably makes no sense anyway under podman-remote, and the other seems to be a variant of #9867. Full log FYI

[edsantiago]

Oh... and my nits are not meant as complaints. This PR allows me to enable forty-eight tests in buildah bud.bats that have so far been skipped! (There are 53 total, but five of those are the problems reported above). Thank you!

[edsantiago]

Interesting. This new revision works much better with podman-remote + buildah-bud.bats, but fails in APIv2 and compose tests with what looks like a real error - one that is not caught by buildah-bud tests!

[edsantiago]

buildah-bud-under-podman also failing with same error as CI:

Error: failed to parse query parameter 'dockerfile': "Dockerfile": invalid character 'D' looking for beginning of value

[edsantiago]

LGTM. A lot more tests are passing.

[mheon]

/lgtm